forked from cloudflare/pingora
-
Notifications
You must be signed in to change notification settings - Fork 0
Add Rustls compile time implementation #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coco-speed
wants to merge
10
commits into
main
Choose a base branch
from
fork-336-hargut/feat/rustls-compile-time-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Rustls compile time implementation #56
coco-speed
wants to merge
10
commits into
main
from
fork-336-hargut/feat/rustls-compile-time-feature
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #56 will not alter performanceComparing Summary
|
e3459e9 to
21bba97
Compare
972578d to
143f455
Compare
5f4f3a5 to
ccdb32c
Compare
use generics instead as used within the original version remove trait implementations for Box<dyn IO + Send> as no longer required
238a17a to
fa851d6
Compare
replace direct field access with getter method that returns &Arc<impl TlsConnectorContext>, store concrete type in now private struct field using impl Trait in return value keeps method signature stable across features; allows for static dispatch adjust visibility for TlsConnectorCtx structs from pub(crate) to pub(super)
d94ad0d to
4b82093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically by CodSpeed to track performance changes of the pull request cloudflare/pingora#336.
The original branch is fork-336-hargut/feat/rustls-compile-time-feature