Skip to content

Conversation

@coco-speed
Copy link
Collaborator

This pull request was created automatically by CodSpeed to track performance changes of the pull request cloudflare/pingora#336.

The original branch is fork-336-hargut/feat/rustls-compile-time-feature

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #56 will not alter performance

Comparing fork-336-hargut/feat/rustls-compile-time-feature (f56d04e) with main (519d1f8)

Summary

✅ 2 untouched benchmarks

@coco-speed coco-speed force-pushed the main branch 2 times, most recently from e3459e9 to 21bba97 Compare July 26, 2024 20:40
@coco-speed coco-speed force-pushed the main branch 2 times, most recently from 972578d to 143f455 Compare August 16, 2024 17:40
@coco-speed coco-speed force-pushed the main branch 2 times, most recently from 5f4f3a5 to ccdb32c Compare August 23, 2024 21:55
use generics instead as used within the original version
remove trait implementations for Box<dyn IO + Send> as no longer required
@coco-speed coco-speed force-pushed the main branch 4 times, most recently from 238a17a to fa851d6 Compare August 30, 2024 18:20
 replace direct field access with getter method that
 returns &Arc<impl TlsConnectorContext>,
 store concrete type in now private struct field

using impl Trait in return value keeps method signature
stable across features; allows for static dispatch

 adjust visibility for TlsConnectorCtx structs from pub(crate) to pub(super)
@coco-speed coco-speed force-pushed the main branch 2 times, most recently from d94ad0d to 4b82093 Compare September 20, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants