-
Notifications
You must be signed in to change notification settings - Fork 6
Cod 1364 runner sample without splitting perfdata #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cod 1364 runner sample without splitting perfdata #119
Conversation
6740e30 to
b4b3c9c
Compare
8c41561 to
79f05c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the perf runner to use a single perf.data file instead of splitting it across multiple files, and extracts shared data structures into a new runner-shared crate.
- Consolidates perf data collection into a single
perf.datafile rather than splitting by process - Moves shared data structures (
UnwindData,PerfMetadata, FIFO commands) to newrunner-sharedcrate - Updates the benchmark tracking mechanism to use timestamps instead of per-process ordering
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/run/runner/wall_time/perf/unwind_data.rs | Converts UnwindData struct to trait and updates implementation to use shared crate |
| src/run/runner/wall_time/perf/mod.rs | Major refactor removing perf data splitting, updating to single file approach with timestamp-based tracking |
| src/run/runner/wall_time/perf/metadata.rs | Removes local metadata struct (moved to shared crate) |
| src/run/runner/wall_time/perf/jit_dump.rs | Updates imports to use shared UnwindData |
| src/run/runner/wall_time/perf/helpers.rs | Removes PID finding logic (no longer needed without data splitting) |
| src/run/runner/wall_time/perf/fifo.rs | Updates to use shared FIFO constants |
| crates/runner-shared/* | New shared crate containing common data structures |
| Cargo.toml | Adds workspace configuration and new dependency |
| Various other files | String formatting updates using more concise syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bf9395d to
1cb23cc
Compare
|
It's weird you had to fix the clippy issues since we have this in the recommit hooks: Did the rust version or anything else change? |
Ahh, I think I'm using a newer Rust version. Should I revert the commit? |
f3baf50 to
ed702f4
Compare
Anyway we'd have to do those changes at some point so we can keep it. Are you using rustup? Normally it picks up the rust-toolchain.toml automatically |
ed702f4 to
a7f7581
Compare
a7f7581 to
4c990fd
Compare
Changes in this PR:
runner-sharedcrate which is used in theperf-parsercrateSetVersioncommand to detect incompatible integrations