feat: proper interactive sudo support #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the handling of interactive sudo password prompts to provide a better user experience when sudo privileges are required.
Changes
1. Pre-validation of sudo access
validate_sudo_access()function that checks if sudo requires a passwordsudo --validateto cache credentials upfront2. Proper progress bar suspension
suspend_progress_bar()insrc/local_logger.rs:30to usetry_lock()instead oflock()to prevent deadlocks on reentrant calls3. Centralized sudo command creation
validated_sudo_command()function that validates sudo access first, then creates a Command with the--non-interactiveflag4. Improved error handling