fix: create perf.pipedata in temporary file to avoid issues with golang #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
requested review from
GuillaumeLagrange,
adriencaccia and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where writing perf.pipedata directly to the profile folder caused problems with Golang benchmarks. The solution creates the perf data file in a temporary location and copies it to the profile folder during teardown.
Key Changes
- Store a
NamedTempFileinPerfRunnerto hold perf data during execution - Remove
profile_folderparameter fromPerfRunner::run()method - Copy perf data from tempfile to profile folder in
save_files_to()method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/run/runner/wall_time/perf/mod.rs | Add perf_file field to store tempfile, update run() to write to tempfile, add copy logic in save_files_to() |
| src/run/runner/wall_time/executor.rs | Remove profile_folder parameter from perf.run() call, add test helper method |
| src/run/runner/tests.rs | Add new test to verify perf data file creation with Go benchmarks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Closing this in favor of CodSpeedHQ/codspeed-go#34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially thought the problems came from the new command builder, but it was actually due to directly writing the perf.pipedata into the profile folder (this is the PR: #138).
I am not yet sure why this is only happening in golang and not with Rust. Creating the profile folder didn't fix this issue. Lmk if you have any theories/ideas what could be the root cause @GuillaumeLagrange @adriencaccia .
I've added a test and reverted the change for now.