mctp utility dosent compile with libsystemd 239

[alokprasad]

I have installed below kernel and all the headers.

Linux neutron 5.19.10 #2 SMP PREEMPT_DYNAMIC Sat Oct 29 03:29:18 EDT 2022 x86_64 x86_64 x86_64 GNU/Linux

After ninja -C obj getting below error.

[root@neutron mctp]# ninja -C obj
ninja: Entering directory `obj'
[2/3] Compiling C object mctpd.p/src_mctpd.c.o
FAILED: mctpd.p/src_mctpd.c.o
cc -Imctpd.p -I. -I.. -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -g -Wno-unused-parameter -MD -MQ mctpd.p/src_mctpd.c.o -MF mctpd.p/src_mctpd.c.o.d -o mctpd.p/src_mctpd.c.o -c ../src/mctpd.c
../src/mctpd.c: In function ‘wait_fd_timeout’:
../src/mctpd.c:318:7: warning: implicit declaration of function ‘sd_event_add_time_relative’; did you mean ‘sd_event_add_time’? [-Wimplicit-function-declaration]
  rc = sd_event_add_time_relative(ev, NULL, CLOCK_MONOTONIC,
       ^~~~~~~~~~~~~~~~~~~~~~~~~~
       sd_event_add_time
../src/mctpd.c: At top level:
../src/mctpd.c:2222:2: warning: implicit declaration of function ‘SD_BUS_METHOD_WITH_NAMES’; did you mean ‘SD_BUS_METHOD_WITH_OFFSET’? [-Wimplicit-function-declaration]
  SD_BUS_METHOD_WITH_NAMES("SetupEndpoint",
  ^~~~~~~~~~~~~~~~~~~~~~~~
  SD_BUS_METHOD_WITH_OFFSET
../src/mctpd.c:2224:3: warning: implicit declaration of function ‘SD_BUS_PARAM’; did you mean ‘SD_BUS_SIGNAL’? [-Wimplicit-function-declaration]
   SD_BUS_PARAM(ifname)
   ^~~~~~~~~~~~
   SD_BUS_SIGNAL
../src/mctpd.c:2224:16: error: ‘ifname’ undeclared here (not in a function); did you mean ‘tzname’?
   SD_BUS_PARAM(ifname)
                ^~~~~~
                tzname
../src/mctpd.c:2224:23: error: expected ‘)’ before ‘SD_BUS_PARAM’
   SD_BUS_PARAM(ifname)
                       ^
                       )
   SD_BUS_PARAM(physaddr),
   ~~~~~~~~~~~~
../src/mctpd.c:2236:23: error: expected ‘)’ before ‘SD_BUS_PARAM’
   SD_BUS_PARAM(ifname)
                       ^
                       )
   SD_BUS_PARAM(physaddr),
   ~~~~~~~~~~~~
../src/mctpd.c:2248:23: error: expected ‘)’ before ‘SD_BUS_PARAM’
   SD_BUS_PARAM(ifname)
                       ^
                       )
   SD_BUS_PARAM(physaddr),
   ~~~~~~~~~~~~
../src/mctpd.c:2265:23: error: expected ‘)’ before ‘SD_BUS_PARAM’
   SD_BUS_PARAM(ifname)
                       ^
                       )
   SD_BUS_PARAM(physaddr)
   ~~~~~~~~~~~~
../src/mctpd.c:2263:2: error: initializer element is not constant
  SD_BUS_METHOD_WITH_NAMES("SendToPhys",
  ^~~~~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:2263:2: note: (near initialization for ‘testing_vtable[1].type’)
../src/mctpd.c:2277:16: error: ‘eid’ undeclared here (not in a function)
   SD_BUS_PARAM(eid)
                ^~~
../src/mctpd.c:2277:20: error: expected ‘)’ before ‘SD_BUS_PARAM’
   SD_BUS_PARAM(eid)
                    ^
                    )
   SD_BUS_PARAM(net)
   ~~~~~~~~~~~~
../src/mctpd.c:2275:2: error: initializer element is not constant
  SD_BUS_METHOD_WITH_NAMES("SendTo",
  ^~~~~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:2275:2: note: (near initialization for ‘testing_vtable[1].flags’)
../src/mctpd.c:2287:16: error: ‘seconds’ undeclared here (not in a function); did you mean ‘send’?
   SD_BUS_PARAM(seconds),
                ^~~~~~~
                send
../src/mctpd.c:2289:16: error: ‘secondsx10’ undeclared here (not in a function); did you mean ‘useconds_t’?
   SD_BUS_PARAM(secondsx10),
                ^~~~~~~~~~
                useconds_t
../src/mctpd.c:2285:2: error: initializer element is not constant
  SD_BUS_METHOD_WITH_NAMES("TestTimer",
  ^~~~~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:2285:2: note: (near initialization for ‘testing_vtable[1].x.start.element_size’)
../src/mctpd.c:2292:2: error: initializer element is not constant
  SD_BUS_METHOD_WITH_NAMES("TestTimerAsync",
  ^~~~~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:2292:2: note: (near initialization for ‘testing_vtable[2].type’)
../src/mctpd.c:2300:2: warning: braces around scalar initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
In file included from /usr/include/systemd/sd-bus.h:114,
                 from ../src/mctpd.c:23:
../src/mctpd.c:2300:2: error: field name not in record or union initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
../src/mctpd.c:2300:2: error: field name not in record or union initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
../src/mctpd.c:2300:2: warning: excess elements in scalar initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
In file included from /usr/include/systemd/sd-bus.h:114,
                 from ../src/mctpd.c:23:
../src/mctpd.c:2300:2: error: field name not in record or union initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
../src/mctpd.c:2300:2: warning: braces around scalar initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
../src/mctpd.c:2300:2: warning: braces around scalar initializer
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
../src/mctpd.c:2300:2: warning: excess elements in scalar initializer
../src/mctpd.c:2300:2: note: (near initialization for ‘testing_vtable[2].flags’)
../src/mctpd.c:2301:1: warning: missing initializer for field ‘x’ of ‘sd_bus_vtable’ {aka ‘const struct sd_bus_vtable’} [-Wmissing-field-initializers]
 };
 ^
In file included from /usr/include/systemd/sd-bus.h:114,
                 from ../src/mctpd.c:23:
/usr/include/systemd/sd-bus-vtable.h:80:11: note: ‘x’ declared here
         } x;
           ^
../src/mctpd.c:2261:47: warning: missing braces around initializer [-Wmissing-braces]
 static const sd_bus_vtable testing_vtable[] = {
                                               ^
../src/mctpd.c:2263:2:
  SD_BUS_METHOD_WITH_NAMES("SendToPhys",
  {
../src/mctpd.c:2285:2:
  SD_BUS_METHOD_WITH_NAMES("TestTimer",
  {{
../src/mctpd.c:2291:5:
   0),
     }}}
  SD_BUS_METHOD_WITH_NAMES("TestTimerAsync",
  {
../src/mctpd.c:2301:1:
 };
 }
../src/mctpd.c:2360:2: warning: implicit declaration of function ‘SD_BUS_METHOD_WITH_ARGS’; did you mean ‘SD_BUS_METHOD_WITH_OFFSET’? [-Wimplicit-function-declaration]
  SD_BUS_METHOD_WITH_ARGS("SetMTU",
  ^~~~~~~~~~~~~~~~~~~~~~~
  SD_BUS_METHOD_WITH_OFFSET
../src/mctpd.c:2361:3: warning: implicit declaration of function ‘SD_BUS_ARGS’; did you mean ‘SD_BUS_SIGNAL’? [-Wimplicit-function-declaration]
   SD_BUS_ARGS("u", mtu),
   ^~~~~~~~~~~
   SD_BUS_SIGNAL
../src/mctpd.c:2361:20: error: ‘mtu’ undeclared here (not in a function)
   SD_BUS_ARGS("u", mtu),
                    ^~~
../src/mctpd.c:2362:3: error: ‘SD_BUS_NO_RESULT’ undeclared here (not in a function); did you mean ‘SD_BUS_DEFAULT’?
   SD_BUS_NO_RESULT,
   ^~~~~~~~~~~~~~~~
   SD_BUS_DEFAULT
../src/mctpd.c:2360:2: error: initializer element is not constant
  SD_BUS_METHOD_WITH_ARGS("SetMTU",
  ^~~~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:2360:2: note: (near initialization for ‘bus_endpoint_cc_vtable[1].type’)
../src/mctpd.c:2366:3: error: ‘SD_BUS_NO_ARGS’ undeclared here (not in a function); did you mean ‘SD_BUS_DEFAULT’?
   SD_BUS_NO_ARGS,
   ^~~~~~~~~~~~~~
   SD_BUS_DEFAULT
../src/mctpd.c:2365:2: error: initializer element is not constant
  SD_BUS_METHOD_WITH_ARGS("Remove",
  ^~~~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:2365:2: note: (near initialization for ‘bus_endpoint_cc_vtable[1].flags’)
In file included from /usr/include/systemd/sd-bus.h:114,
                 from ../src/mctpd.c:23:
../src/mctpd.c:2370:2: error: ‘union <anonymous>’ has no member named ‘type’
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2370:2: error: ‘union <anonymous>’ has no member named ‘flags’
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2370:2: warning: excess elements in union initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2370:2: note: (near initialization for ‘bus_endpoint_cc_vtable[1].x’)
In file included from /usr/include/systemd/sd-bus.h:114,
                 from ../src/mctpd.c:23:
../src/mctpd.c:2370:2: error: ‘union <anonymous>’ has no member named ‘x’
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2370:2: error: extra brace group at end of initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2370:2: note: (near initialization for ‘bus_endpoint_cc_vtable[1].x’)
../src/mctpd.c:2370:2: error: extra brace group at end of initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2370:2: note: (near initialization for ‘bus_endpoint_cc_vtable[1].x’)
../src/mctpd.c:2370:2: warning: excess elements in union initializer
  SD_BUS_VTABLE_END
  ^~~~~~~~~~~~~~~~~
../src/mctpd.c:2370:2: note: (near initialization for ‘bus_endpoint_cc_vtable[1].x’)
../src/mctpd.c: In function ‘fill_uuid’:
../src/mctpd.c:3109:7: warning: implicit declaration of function ‘sd_id128_get_boot_app_specific’; did you mean ‘sd_id128_get_machine_app_specific’? [-Wimplicit-function-declaration]
  rc = sd_id128_get_boot_app_specific(appid, u);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       sd_id128_get_machine_app_specific
At top level:
../src/mctpd.c:2063:12: warning: ‘method_sendto_addr’ defined but not used [-Wunused-function]
 static int method_sendto_addr(sd_bus_message *call, void *data, sd_bus_error *berr)
            ^~~~~~~~~~~~~~~~~~
../src/mctpd.c:1994:12: warning: ‘method_sendto_phys’ defined but not used [-Wunused-function]
 static int method_sendto_phys(sd_bus_message *call, void *data, sd_bus_error *berr)
            ^~~~~~~~~~~~~~~~~~
../src/mctpd.c:1769:12: warning: ‘method_learn_endpoint’ defined but not used [-Wunused-function]
 static int method_learn_endpoint(sd_bus_message *call, void *data, sd_bus_error *berr)
            ^~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:1713:12: warning: ‘method_assign_endpoint’ defined but not used [-Wunused-function]
 static int method_assign_endpoint(sd_bus_message *call, void *data, sd_bus_error *berr)
            ^~~~~~~~~~~~~~~~~~~~~~
../src/mctpd.c:1648:12: warning: ‘method_setup_endpoint’ defined but not used [-Wunused-function]
 static int method_setup_endpoint(sd_bus_message *call, void *data, sd_bus_error *berr)
            ^~~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

[alokprasad]

Output of meson obj

[root@neutron mctp]# meson obj
The Meson build system
Version: 0.60.2
Source dir: /home/mctp
Build dir: /home/mctp/obj
Build type: native build
Project name: mctp
Project version: v1.0
C compiler for the host machine: cc (gcc 8.4.1 "cc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1)")
C linker for the host machine: cc ld.bfd 2.30-93
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (1.4.2)
Run-time dependency libsystemd found: YES 239
Has header "linux/mctp.h" : YES
Configuring config.h using configuration
Build targets in project: 4

Found ninja-1.10.2.git.kitware.jobserver-1 at /usr/local/bin/ninja

[jk-ozlabs]

Looks like your libsystemd headers are pretty old; we're compiling on version 251 here, your environment is 239.

We'll probably want to add a minimum version to the pkg-config check, for a better error message.

[alokprasad]

I think we should also provide option to compile without systemd lib,
251 is quite latest and not all the distro supports has in their distribution.

[jk-ozlabs]

The libsystemd dependency is entirely optional; if it's not found on your system, then the build should still be OK, but won't have d-bus support.

So, you should be able to build without the libsystemd-devel package installed at all. The issue here is that we're finding it, but can't compile with that version. We could fix this by either requiring a minimum version, or add an explicit disable flag.

[jk-ozlabs]

but won't have d-bus support.

to clarify: d-bus support is required for the mctpd daemon - this won't be build when libsystemd is not available.

[jk-ozlabs]

It looks like the latest dependency there is on sd_event_add_time_relative, introduced in systemd 247.

[jk-ozlabs]

Can you test with the pr/libsystemd-version branch?

https://github.com/CodeConstruct/mctp/tree/pr/libsystemd-version

That will disable the libsystemd dependency if we don't find v247 or later.

[alokprasad]

This works fine.

[root@neutron mctp]# meson obj
The Meson build system
Version: 0.60.2
Source dir: /tmp/mctp
Build dir: /tmp/mctp/obj
Build type: native build
Project name: mctp
Project version: v1.0
C compiler for the host machine: cc (gcc 8.4.1 "cc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1)")
C linker for the host machine: cc ld.bfd 2.30-93
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (1.4.2)
Dependency libsystemd found: NO found 239 but need: '>=247'
Found CMake: /usr/bin/cmake (3.18.2)
Run-time dependency libsystemd found: NO (tried pkgconfig and cmake)
Has header "linux/mctp.h" : YES
Configuring config.h using configuration
Build targets in project: 3

Found ninja-1.10.2.git.kitware.jobserver-1 at /usr/local/bin/ninja
[root@neutron mctp]# ninja -C obj
ninja: Entering directory `obj'
[10/10] Linking target mctp

[alokprasad]

Fixed via a020fac