fix: take base url into account in icon src path#60
Merged
CodeDevMLH merged 3 commits intoCodeDevMLH:devfrom Apr 8, 2026
Merged
fix: take base url into account in icon src path#60CodeDevMLH merged 3 commits intoCodeDevMLH:devfrom
CodeDevMLH merged 3 commits intoCodeDevMLH:devfrom
Conversation
Refactor script loading logic to ensure proper insertion of YouTube API script (fix CodeDevMLH#58)
Owner
|
Thanks for the fix and the "bug" report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a base url is configured in jellyfin, the media bar settings icon will fail to load.
Pass the asset path through
window.ApiClient.getUrl()so that it includes the base path if it's set.