fix (652): weird behaviour of decimal input in exercise entry edit

[Sim-sat]

Description

Fixes the bug explained in #652

Forced decimal conversion of the input is not needed and was the cause of the issue. I also fixed the issue that deleting the last number would result in a 0 (cause "" is 0) and only enter a zero on blur

[gemini-code-assist]

Summary of Changes

Hello @Sim-sat, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves two related bugs within the exercise entry editing dialog. It specifically fixes an issue with decimal input fields behaving unexpectedly due to an unnecessary formatting function and improves the handling of empty weight inputs to prevent premature zero assignment, ensuring a more intuitive user experience.

Highlights

• Decimal Input Behavior Fixed: Resolved an issue where decimal inputs in the exercise entry editor exhibited unexpected behavior due to an unnecessary forced decimal conversion, as reported in [Bug]: Weird behaviour of decimal input in exercise entry edit #652.
• Empty Weight Input Handling Improved: Corrected the behavior where deleting the last number in the weight input would incorrectly result in a '0' value; now, an empty input on blur will correctly set the value to '0', preventing premature zero assignment.
• Removed formatWeight Utility: Eliminated the formatWeight utility function from the weight input's value binding, simplifying input handling and addressing the root cause of the decimal input bug.

Changelog

• SparkyFitnessFrontend/src/pages/Diary/EditExerciseEntryDialog.tsx
  • Removed the import and usage of the formatWeight utility function.
  • Modified the onChange handler for the weight input to correctly parse numeric values, treating empty strings as null.
  • Added an onBlur handler to the weight input to set its value to 0 only when the field is empty upon losing focus.

Activity

• No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix an issue with decimal input fields. While the intention is good, the implementation introduces new problems, such as making it difficult to enter decimal values and creating a potential for errors when saving. The fix is also applied inconsistently, leaving other similar input fields with the original bug. I've provided feedback on how to address these issues for a more robust solution.