chore: add eslintignore and prettierignore#671
Conversation
Summary of ChangesHello @Sim-sat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces configuration files for ESLint and Prettier to exclude specific directories from their respective linting and formatting processes. This ensures that only relevant source code is analyzed and formatted, improving performance and preventing conflicts with generated or third-party files. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds .eslintignore and .prettierignore files. While the .prettierignore file is appropriate, the .eslintignore file is not the correct approach for this project's configuration. The project uses a modern eslint.config.js (flat config), which does not support .eslintignore files. All ignore patterns should be consolidated within eslint.config.js. I have added a comment with a detailed explanation and a suggested fix.
| build/ | ||
| coverage/ | ||
| dist/ | ||
| node_modules/ |
There was a problem hiding this comment.
With the project using a flat configuration file (eslint.config.js), this .eslintignore file is no longer supported and will be ignored by ESLint. The correct way to specify ignored files is within eslint.config.js using the ignores property.
The eslint.config.js file already ignores the dist directory. To ignore the other directories from this file, you should update eslint.config.js:
// eslint.config.js
export default tseslint.config(
{ ignores: ['dist', 'build/', 'coverage/'] },
// ... rest of the config
);node_modules is ignored by ESLint by default, so it doesn't need to be explicitly added.
To fix this, please remove the .eslintignore file and update eslint.config.js as shown above. This keeps the configuration centralized and effective.
No description provided.