Skip to content

Update grantPermissions.js to use double quotes #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeWithCJ merged 3 commits into from
Feb 22, 2026
Merged

Update grantPermissions.js to use double quotes #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b31e581
Update grantPermissions.js to use double quotes
toddejohnson Feb 22, 2026
ae0f5ce
Escape quotes in appUser for SQL safety
toddejohnson Feb 22, 2026
30c01a4
Escape quotes in database user environment variable
toddejohnson Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions SparkyFitnessServer/db/grantPermissions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,42 +3,42 @@ const { log } = require('../config/logging');

async function grantPermissions() {
const client = await getSystemClient();
const appUser = process.env.SPARKY_FITNESS_APP_DB_USER;
const appUser = `"${process.env.SPARKY_FITNESS_APP_DB_USER.replace(/"/g, '""')}"`;

try {
log('info', `Ensuring permissions for role: ${appUser}`);
log('info', `Ensuring permissions for role: "${appUser}"`);

// Grant usage on schemas
await client.query(`GRANT USAGE ON SCHEMA public TO ${appUser}`);
await client.query(`GRANT USAGE ON SCHEMA auth TO ${appUser}`);
await client.query(`GRANT USAGE ON SCHEMA system TO ${appUser}`);
await client.query(`GRANT USAGE ON SCHEMA public TO "${appUser}"`);
await client.query(`GRANT USAGE ON SCHEMA auth TO "${appUser}"`);
await client.query(`GRANT USAGE ON SCHEMA system TO "${appUser}"`);


// Grant permissions on all tables in the public schema
await client.query(`GRANT SELECT, INSERT, UPDATE, DELETE ON ALL TABLES IN SCHEMA public TO ${appUser}`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT SELECT, INSERT, UPDATE, DELETE ON TABLES TO ${appUser}`);
await client.query(`GRANT SELECT, INSERT, UPDATE, DELETE ON ALL TABLES IN SCHEMA public TO "${appUser}"`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT SELECT, INSERT, UPDATE, DELETE ON TABLES TO "${appUser}"`);

// Grant permissions on all sequences in the public schema
await client.query(`GRANT USAGE, SELECT ON ALL SEQUENCES IN SCHEMA public TO ${appUser}`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT USAGE, SELECT ON SEQUENCES TO ${appUser}`);
await client.query(`GRANT USAGE, SELECT ON ALL SEQUENCES IN SCHEMA public TO "${appUser}"`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT USAGE, SELECT ON SEQUENCES TO "${appUser}"`);

// Grant permissions on all tables in the auth schema
await client.query(`GRANT SELECT, INSERT, UPDATE, DELETE ON ALL TABLES IN SCHEMA auth TO ${appUser}`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA auth GRANT SELECT, INSERT, UPDATE, DELETE ON TABLES TO ${appUser}`);
await client.query(`GRANT SELECT, INSERT, UPDATE, DELETE ON ALL TABLES IN SCHEMA auth TO "${appUser}"`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA auth GRANT SELECT, INSERT, UPDATE, DELETE ON TABLES TO "${appUser}"`);

// Grant permissions on all functions in the public schema
await client.query(`GRANT EXECUTE ON ALL FUNCTIONS IN SCHEMA public TO ${appUser}`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT EXECUTE ON FUNCTIONS TO ${appUser}`);
await client.query(`GRANT EXECUTE ON ALL FUNCTIONS IN SCHEMA public TO "${appUser}"`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA public GRANT EXECUTE ON FUNCTIONS TO "${appUser}"`);

// Grant permissions on all functions in the auth schema
await client.query(`GRANT EXECUTE ON ALL FUNCTIONS IN SCHEMA auth TO ${appUser}`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA auth GRANT EXECUTE ON FUNCTIONS TO ${appUser}`);
await client.query(`GRANT EXECUTE ON ALL FUNCTIONS IN SCHEMA auth TO "${appUser}"`);
await client.query(`ALTER DEFAULT PRIVILEGES IN SCHEMA auth GRANT EXECUTE ON FUNCTIONS TO "${appUser}"`);

// Grant select on schema_migrations to check applied migrations
await client.query(`GRANT SELECT ON system.schema_migrations TO ${appUser}`);
await client.query(`GRANT SELECT ON system.schema_migrations TO "${appUser}"`);


log('info', `Successfully ensured permissions for role: ${appUser}`);
log('info', `Successfully ensured permissions for role: "${appUser}"`);
} catch (error) {
log('error', 'Error granting permissions:', error);
process.exit(1); // Exit if permissions cannot be granted
Expand Down
2 changes: 1 addition & 1 deletion SparkyFitnessServer/utils/dbMigrations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ async function applyMigrations() {
const client = await getSystemClient();
try {
// The preflightChecks.js script now ensures these variables are set.
const appUser = process.env.SPARKY_FITNESS_APP_DB_USER;
const appUser = `"${process.env.SPARKY_FITNESS_APP_DB_USER.replace(/"/g, '""')}"`;
const appPassword = process.env.SPARKY_FITNESS_APP_DB_PASSWORD;

// Ensure the application role exists
Expand Down