Mobile App UI and storage fixes, Exercise Sets Fix #717
Mobile App UI and storage fixes, Exercise Sets Fix #717CodeWithCJ merged 6 commits intoCodeWithCJ:mainfrom
Conversation
Moved to standard bg, surface, raised, chrome
Summary of ChangesHello @apedley, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a series of enhancements aimed at refining the application's user experience and bolstering its security posture. It addresses the accurate representation of exercise durations within synced entries and establishes a consistent visual language through standardized background color variables. Furthermore, the introduction of swipe gestures streamlines daily navigation, while a critical security upgrade ensures API keys are stored using encrypted methods. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request provides a significant UI polish, standardizing background colors and improving navigation with gestures. The migration of API keys to SecureStore is a critical security improvement. However, I identified a logic error in the Dashboard's conditional rendering that could hide the main calorie tracking card under common scenarios, and a potential race condition in the storage migration logic. I have also suggested some code cleanup for messy indentation and redundant logic.
| {(summary.foodEntries.length > 0 || summary.exerciseEntries.length > 0) && | ||
| (summary.exerciseMinutesGoal > 0 || summary.exerciseCaloriesGoal > 0 || summary.exerciseMinutes > 0 || summary.otherExerciseCalories > 0) && ( | ||
|
|
There was a problem hiding this comment.
This condition is redundant because it is already inside the 'else' branch of a ternary (line 196) that checks if both food and exercise entries are empty. If we reach this point, we already know at least one of them has entries.
apedley
changed the title
2 participants
Fixed exercise entry sync to use a default set, allowing the duration to display (#642)
Standardized structure of backgrounds (background, surface, raised, chrome)
Gestures for navigation between days
Moved API key to encrypted storage