refactor(settings): migrated setting to TSQ and refactor large components#738
Merged
CodeWithCJ merged 2 commits intoCodeWithCJ:mainfrom Feb 25, 2026
Merged
refactor(settings): migrated setting to TSQ and refactor large components#738CodeWithCJ merged 2 commits intoCodeWithCJ:mainfrom
CodeWithCJ merged 2 commits intoCodeWithCJ:mainfrom
Conversation
components - migration of whole settings directoriy to tanstack query - split up SparkyFitnessFrontend/src/pages/Settings/SettingsPage.tsx and moved code into seperate components - split up the provider logic into view and form - created api functions for every bare api call
16 tasks
Contributor
Summary of ChangesHello @Sim-sat, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring of the application's settings functionality. The primary goal was to modernize data management by migrating all settings-related data fetching and state to Tanstack Query. This transition not only streamlines data handling but also modularizes the settings page into smaller, more focused components, improving code organization and future extensibility. The changes also address previous issues with stale data by replacing legacy event-based refreshes with Tanstack Query's efficient caching and invalidation strategies. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This is an excellent and extensive refactoring. Migrating to TanStack Query and breaking down large components into smaller, more focused ones significantly improves the codebase's maintainability, testability, and overall structure. The new API service layer and custom hooks are well-designed abstractions. I've left a few comments on minor inconsistencies and areas for further improvement, but overall, this is a fantastic contribution.
SparkyFitnessFrontend/src/api/Settings/externalProviderService.ts
Outdated
Show resolved
Hide resolved
CodeWithCJ
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The amount of lines changed is quite high but I changed very little just moved the code to different files. We now have a organized Settings and Provider page (before they had 1700 lines)