fix(lint): no require imports#797
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the codebase's adherence to linting standards and streamlining the development experience for tests. It addresses a specific Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully addresses the no-require-imports linting error by replacing a require() call with a modern import statement. Additionally, it disables the @typescript-eslint/no-explicit-any rule for test files to remove several eslint-disable comments. While the move to import is a good improvement, I have a suggestion regarding the complete disabling of no-explicit-any in tests, as it can impact the long-term maintainability and type-safety of the test suite.
Description
Fixes the 1 no-require-imports error from eslint. It also removes the no-explicit-any rule for test files since it's not a problem there.
Related Issue
PR type [ ] Issue [x] New Feature [ ] Documentation
Linked Issue: #795
Checklist
Please check all that apply:
pnpm run validate(especially for Frontend).en) translation file (if applicable).rls_policies.sqlfor any new user-specific tables.