build: fix frontend docker build and runtime errors#809
Conversation
- Update Dockerfiles to use pnpm@10.30.3 and include pnpm-workspace.yaml - Fix Auth UI bug where magic link modal appeared by default - Resolve production 'createContext' error via React deduplication in Vite - Add packageManager to root package.json for version enforcement - Cleanup redundant package-lock.json and bun.lockb files
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the stability and consistency of the frontend development and deployment process. It standardizes the package manager version used in Docker builds, resolves a critical production build error related to React context, and fixes an annoying UI bug in the authentication flow. These changes contribute to a more robust and predictable development experience. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several fixes and improvements to the frontend build process and runtime behavior. The Dockerfiles are updated to use a pinned version of pnpm (10.30.3), and the root package.json now enforces this version, which enhances build reproducibility. A runtime bug with the magic link modal is fixed by using conditional rendering. Additionally, a potential production error is addressed by deduplicating react and react-dom in the Vite config.
While reviewing, I noticed that in docker/Dockerfile.frontend, the base image nginx:alpine3.22 is used. This tag does not appear to be valid on Docker Hub and will likely cause the build to fail. You may want to replace it with a valid tag, such as nginx:alpine or a specific version like nginx:1.27.0-alpine.
Tip
Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run
pnpm run validateto check for any errors.PRs that include tests and clear screenshots are highly preferred!
Description
Provide a brief summary of your changes.
Related Issue
PR type [ ] Issue [ ] New Feature [ ] Documentation
Linked Issue: #
Checklist
Please check all that apply:
pnpm run validate(especially for Frontend).en) translation file (if applicable).rls_policies.sqlfor any new user-specific tables.Screenshots (if applicable)
Before
[Insert screenshot/GIF here]
After
[Insert screenshot/GIF here]