Skip to content

removal of duplicate declaration in root package and vite manual chun…#810

Merged
CodeWithCJ merged 1 commit intomainfrom
dev
Mar 1, 2026
Merged

removal of duplicate declaration in root package and vite manual chun…#810
CodeWithCJ merged 1 commit intomainfrom
dev

Conversation

@CodeWithCJ
Copy link
Owner

removal of duplicate declaration in root package and vite manual chunk fixes.

Tip

Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run pnpm run validate to check for any errors.
PRs that include tests and clear screenshots are highly preferred!

Description

Provide a brief summary of your changes.

Related Issue

PR type [x] Issue [ ] New Feature [ ] Documentation
Linked Issue: # #808

Checklist

Please check all that apply:

  • [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers
  • Tests: I have included automated tests for my changes.
  • [MANDATORY for UI changes] Screenshots: I have attached "Before" vs "After" screenshots below.
  • [MANDATORY for Frontend changes] Quality: I have run pnpm run validate (especially for Frontend).
  • Translations: I have only updated the English (en) translation file (if applicable).
  • Architecture: My code follows the existing architecture standards.
  • Database Security: I have updated rls_policies.sql for any new user-specific tables.
  • [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code(phishing, malware, etc.) and I agree to the License terms.

Screenshots (if applicable)

Before

[Insert screenshot/GIF here]

After

[Insert screenshot/GIF here]

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the project's dependency management and build configuration. It removes an unused drag-and-drop library and its types, streamlines the Vite build process by adjusting manual chunking, and addresses potential issues with the package-lock.json file. These changes aim to reduce the project's footprint and optimize the build.

Highlights

  • Dependency Cleanup: The react-beautiful-dnd library and its associated type definitions have been removed from the project dependencies.
  • Vite Configuration Update: The manual chunking configuration in Vite has been adjusted to no longer create a separate vendor chunk for leaflet.
  • Package Lock File Removal: The package-lock.json file has been removed, indicating a potential shift in dependency management strategy or a refresh of the lock file.
Changelog
  • SparkyFitnessFrontend/vite.config.ts
    • Removed the manual chunking rule for 'leaflet' from the build optimization configuration.
  • package-lock.json
    • Deleted the 'package-lock.json' file.
  • package.json
    • Removed 'react-beautiful-dnd' and '@types/react-beautiful-dnd' from the 'dependencies' list.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@CodeWithCJ CodeWithCJ merged commit 8300f97 into main Mar 1, 2026
6 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes some dependencies from the root package.json and adjusts the Vite manual chunking configuration. While these changes seem reasonable, the removal of the root package-lock.json is a major concern. This file is crucial for ensuring reproducible builds, and its removal can lead to inconsistencies across different development and CI environments. I've left a critical comment regarding this issue. Please restore the lock file or replace it with the appropriate one for your package manager (e.g., pnpm-lock.yaml).

@@ -1,1071 +0,0 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Removing the package-lock.json file is a critical issue as it breaks reproducible builds. This file ensures that the exact same dependency versions are installed across different environments (e.g., developer machines, CI/CD). Without it, npm install might install newer versions of dependencies, which could introduce breaking changes or unexpected behavior.

If the goal is to migrate to another package manager like pnpm (which seems to be used in the frontend), a pnpm-lock.yaml file should be generated and committed at the repository root instead. Please either restore this file or add the appropriate lock file for the package manager being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant