Skip to content

fix(lint): no-explicit-any in api/CheckIn#826

Merged
CodeWithCJ merged 1 commit intoCodeWithCJ:mainfrom
Sim-sat:no-explicit-any-checkin
Mar 3, 2026
Merged

fix(lint): no-explicit-any in api/CheckIn#826
CodeWithCJ merged 1 commit intoCodeWithCJ:mainfrom
Sim-sat:no-explicit-any-checkin

Conversation

@Sim-sat
Copy link
Contributor

@Sim-sat Sim-sat commented Mar 3, 2026

Description

Removes explicit anys from api/CheckIn.

Related Issue

PR type [ ] Issue [x] New Feature [ ] Documentation
Linked Issue: #795

Checklist

Please check all that apply:

  • [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers
  • Tests: I have included automated tests for my changes.
  • [MANDATORY for UI changes] Screenshots: I have attached "Before" vs "After" screenshots below.
  • [MANDATORY for Frontend changes] Quality: I have run pnpm run validate (especially for Frontend).
  • Translations: I have only updated the English (en) translation file (if applicable).
  • Architecture: My code follows the existing architecture standards.
  • Database Security: I have updated rls_policies.sql for any new user-specific tables.
  • [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code(phishing, malware, etc.) and I agree to the License terms.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the type safety and code quality within the api/CheckIn directory by removing explicit any type declarations and introducing more specific type definitions. This enhances the maintainability and reduces potential runtime errors.

Highlights

  • Explicit any Removal: This PR removes instances of any type declarations in api/CheckIn and replaces them with more specific types, enhancing type safety.
  • Improved Type Definitions: The PR introduces interfaces like MoodEntryParams and uses Partial<CheckInMeasurement> and Partial<CustomMeasurement> to provide better type definitions for API payloads.
Changelog
  • api/CheckIn/checkInService.ts
    • Removed explicit any types and replaced them with CheckInMeasurement and CustomMeasurement[] for API responses.
    • Updated saveCheckInMeasurements and saveCustomMeasurement to use Partial<CheckInMeasurement> and Partial<CustomMeasurement> respectively.
  • api/CheckIn/moodService.ts
    • Introduced MoodEntryParams interface for better type safety.
    • Replaced any type for params with MoodEntryParams in getMoodEntries function.
Activity
  • The PR addresses issue Eslint errors in Frontend #795, which likely requested the removal of no-explicit-any linting errors.
  • The author, Sim-sat, has included a checklist confirming tests, code quality validation, adherence to architecture standards, and integrity/license compliance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully addresses the stated goal of removing explicit any types from the api/CheckIn directory. The changes improve type safety and code maintainability by replacing any with more specific types like CheckInMeasurement, CustomMeasurement[], and Partial<CheckInMeasurement>, and by introducing a new interface MoodEntryParams where appropriate. All modifications are well-implemented and align with best practices for TypeScript development.

@CodeWithCJ CodeWithCJ merged commit be2a5c5 into CodeWithCJ:main Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants