Skip to content

fix(lint): no-explicit-any for components, hooks, lib#834

Merged
CodeWithCJ merged 2 commits intoCodeWithCJ:mainfrom
Sim-sat:no-explicit-any-hooks
Mar 3, 2026
Merged

fix(lint): no-explicit-any for components, hooks, lib#834
CodeWithCJ merged 2 commits intoCodeWithCJ:mainfrom
Sim-sat:no-explicit-any-hooks

Conversation

@Sim-sat
Copy link
Contributor

@Sim-sat Sim-sat commented Mar 3, 2026

Description

Removes explicit anys from Components, Hooks and lib

Related Issue

PR type [ ] Issue [x] New Feature [ ] Documentation
Linked Issue: #795

Checklist

Please check all that apply:

  • [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers
  • Tests: I have included automated tests for my changes.
  • [MANDATORY for UI changes] Screenshots: I have attached "Before" vs "After" screenshots below.
  • [MANDATORY for Frontend changes] Quality: I have run pnpm run validate (especially for Frontend).
  • Translations: I have only updated the English (en) translation file (if applicable).
  • Architecture: My code follows the existing architecture standards.
  • Database Security: I have updated rls_policies.sql for any new user-specific tables.
  • [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code(phishing, malware, etc.) and I agree to the License terms.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the type safety and maintainability of the SparkyFitnessFrontend codebase by eliminating the use of explicit any types in components, hooks, and utility libraries. The changes involve replacing any with more specific types or unknown where appropriate, and defining new interfaces to provide better type information. This should reduce potential runtime errors and improve the overall quality of the code.

Highlights

  • Explicit any Removal: This PR focuses on removing explicit any types from the codebase, specifically in Components, Hooks, and lib directories, enhancing type safety.
  • Improved Type Definitions: Replaced any with more specific types like unknown and defined interfaces to provide better type information.
  • Enhanced Code Clarity: By removing eslint-disable-next-line @typescript-eslint/no-explicit-any comments and replacing them with proper type definitions, the code becomes more maintainable and easier to understand.
Activity
  • The PR addresses issue Eslint errors in Frontend #795.
  • The PR includes changes in several components (ExerciseActivityDetailsEditor, BarcodeScanner, CustomFoodForm, OidcCallback, OnBoardingSteps) and hooks (useApiKeys, useAuth).
  • The changes primarily focus on replacing any types with more specific types or unknown.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a good job of removing any types across several components, hooks, and library files, which significantly improves type safety. The changes are generally well-implemented by replacing any with more specific types or unknown. I've found a couple of spots where the refactoring could be improved to be more robust and prevent potential type errors. My detailed comments are below.

@CodeWithCJ CodeWithCJ merged commit cfae249 into CodeWithCJ:main Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants