Skip to content

fix(lint): fix remaining no-explicit-any errors#837

Merged
CodeWithCJ merged 1 commit intoCodeWithCJ:mainfrom
Sim-sat:no-explicit-any-pages
Mar 4, 2026
Merged

fix(lint): fix remaining no-explicit-any errors#837
CodeWithCJ merged 1 commit intoCodeWithCJ:mainfrom
Sim-sat:no-explicit-any-pages

Conversation

@Sim-sat
Copy link
Contributor

@Sim-sat Sim-sat commented Mar 4, 2026

Description

Related Issue

PR type [ ] Issue [x] New Feature [ ] Documentation
Linked Issue: #825

Checklist

Please check all that apply:

  • [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers
  • Tests: I have included automated tests for my changes.
  • [MANDATORY for UI changes] Screenshots: I have attached "Before" vs "After" screenshots below.
  • [MANDATORY for Frontend changes] Quality: I have run pnpm run validate (especially for Frontend).
  • Translations: I have only updated the English (en) translation file (if applicable).
  • Architecture: My code follows the existing architecture standards.
  • Database Security: I have updated rls_policies.sql for any new user-specific tables.
  • [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code(phishing, malware, etc.) and I agree to the License terms.

@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@Sim-sat
Copy link
Contributor Author

Sim-sat commented Mar 4, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant step forward in improving the codebase's type safety by eliminating explicit any types. The extensive refactoring across numerous files to introduce more specific types, centralize type definitions, and clean up redundant code is commendable. I've identified a few instances where unsafe type casts like as unknown as T are used to bridge type mismatches. While this satisfies the linter, it bypasses the type system's safety checks. I've left specific comments with suggestions on how to resolve these by aligning the types, which would make the code even more robust and maintainable. Overall, this is a high-quality contribution that greatly enhances the project's code quality.

Note: Security Review is unavailable for this PR.

@CodeWithCJ CodeWithCJ merged commit 9751f4f into CodeWithCJ:main Mar 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with displaying food from online databases Eslint errors in Frontend

2 participants