Merged
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the frontend's code quality and maintainability by enabling and addressing issues arising from strict TypeScript compiler options. The changes ensure better type safety, eliminate unused code, and standardize error handling. A key functional improvement is the refactoring of food entry cache invalidation, which resolves a bug where nutrition data was not updating correctly, leading to a more reliable user experience. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a great step towards improving the codebase's type safety by enabling several strict TypeScript rules. The changes consistently address issues like unused variables, implicit any types, and improve function signatures. The refactoring of query invalidations into a custom useFoodEntryInvalidation hook is a particularly nice improvement for maintainability, and it also fixes a bug where nutrition data wasn't updating.
I've found one minor issue related to what appears to be leftover debugging code. My feedback is included in the comments below.
Note: Security Review did not run due to the size of the PR.
Comment on lines
+19
to
+22
| if (isDialogOpen) { | ||
| console.log(reviewItems); | ||
| setIsDialogOpen(false); | ||
| } |
Contributor
There was a problem hiding this comment.
This if block appears to be dead code. The isDialogOpen state is initialized to false and is never updated to true, so this condition will never be met. Additionally, it contains a console.log, which should generally be avoided in production code. It seems like this might be leftover debugging code and can be safely removed.
Contributor
Author
There was a problem hiding this comment.
GlobalNotificationIcon is not yet implemented. This code only removes typescript errors from it
CodeWithCJ
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes 4 typescript rules in preparation of strict typescript:
Also adds (but no fixes required):
I also realized the mini nutrion data doesn't update when adding a food so I added the required invalidation.
Edit:
I just saw #842 and decided to add it here since it's just one line.
Related Issue
PR type [ ] Issue [x] New Feature [ ] Documentation
Linked Issue: #842
Checklist
Please check all that apply:
pnpm run validate(especially for Frontend).en) translation file (if applicable).rls_policies.sqlfor any new user-specific tables.