Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining and expanding the project's documentation. The changes aim to provide clearer instructions and better context for users, particularly concerning environment variable setup for Docker Compose, OIDC authentication configuration, and general documentation accuracy. The updates improve the overall user experience by making essential information more accessible and understandable. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides several documentation updates, which mostly improve clarity and organization. I've identified a few areas for improvement, including markdown syntax errors, typos, duplicated content, and sections where the descriptions could be clearer. My specific comments offer suggestions to address these points.
Note: Security Review has been skipped due to the limited scope of the PR.
| - **`ALLOW_PRIVATE_NETWORK_CORS`**: Set to `true` to allow Cross-Origin Resource Sharing (CORS) from private network addresses (e.g., `192.168.x.x`, `10.x.x.x`, `127.0.0.1`, `localhost`). This allows standard browser requests from local IPs. Use with caution. | ||
| - **`SPARKY_FITNESS_EXTRA_TRUSTED_ORIGINS`**: A comma-separated list of additional URLs that Better Auth should trust (e.g., `http://192.168.1.175:8080,http://10.0.0.5:8080`). Use this if you are accessing the app from specific local IPs on your network and `ALLOW_PRIVATE_NETWORK_CORS` is enabled. |
| - **ID Token Signed Response Algorithm**: The algorithm used to sign the ID Token (e.g., `RS256`, `ES256`). | ||
| - **Userinfo Signed Response Algorithm**: The algorithm used to sign the UserInfo response. |
There was a problem hiding this comment.
The previous version of this documentation included helpful troubleshooting advice for these settings, which has been removed. This information was valuable for users. Please consider re-adding it.
| - **ID Token Signed Response Algorithm**: The algorithm used to sign the ID Token (e.g., `RS256`, `ES256`). | |
| - **Userinfo Signed Response Algorithm**: The algorithm used to sign the UserInfo response. | |
| - **ID Token Signed Response Algorithm**: The algorithm used to sign the ID Token (e.g., `RS256`, `ES256`). If you are facing "invalid signature" or "algorithm mismatch" errors, this is a setting to check. | |
| - **Userinfo Signed Response Algorithm**: The algorithm used to sign the UserInfo response. Some providers may require this to be set to a specific value, or `none` if the UserInfo response is not signed. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Tip
Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run
pnpm run validateto check for any errors.PRs that include tests and clear screenshots are highly preferred!
Description
Provide a brief summary of your changes.
Related Issue
PR type [ ] Issue [ ] New Feature [x] Documentation
Linked Issue: #
Checklist
Please check all that apply:
pnpm run validate(especially for Frontend).en) translation file (if applicable).rls_policies.sqlfor any new user-specific tables.Screenshots (if applicable)
Before
[Insert screenshot/GIF here]
After
[Insert screenshot/GIF here]