Revert "Fix auth routes rate limiter, remove duplicate entry"#881
Revert "Fix auth routes rate limiter, remove duplicate entry"#881CodeWithCJ merged 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a full revert of a previous change (PR #878) that aimed to optimize rate limiting for authentication routes and eliminate a redundant route definition. Consequently, the server's authentication rate limiting configuration has been reset to its state before the original fix, and a duplicate route entry has been restored. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that fixed issues with rate limiting and a duplicate route registration. As a result, this PR re-introduces a critical security vulnerability by removing rate limiting from authentication endpoints, and also brings back a duplicate route definition. My review includes comments to address these regressions.
| app.use("/api/sleep", sleepRoutes); | ||
| app.use("/api/sleep-science", sleepScienceRoutes); | ||
| app.use("/api/auth", authLimiter, authRoutes); | ||
| app.use("/api/auth", authRoutes); |
There was a problem hiding this comment.
Removing the authLimiter from this route is a critical security regression that leaves the endpoint vulnerable to brute-force attacks. Please restore the rate limiter.
| app.use("/api/auth", authRoutes); | |
| app.use("/api/auth", authLimiter, authRoutes); |
| app.use("/api/admin/oidc-settings", require("./routes/oidcSettingsRoutes")); | ||
| app.use("/api/admin/backup", backupRoutes); | ||
| app.use("/api/admin/auth", authLimiter, adminAuthRoutes); | ||
| app.use("/api/admin/auth", adminAuthRoutes); |
There was a problem hiding this comment.
Removing the authLimiter from this admin route is a critical security regression that leaves the endpoint vulnerable to brute-force attacks. Please restore the rate limiter.
| app.use("/api/admin/auth", adminAuthRoutes); | |
| app.use("/api/admin/auth", authLimiter, adminAuthRoutes); |
| app.use("/api/mood", moodRoutes); | ||
| app.use("/api/fasting", fastingRoutes); | ||
| app.use("/api/admin", adminRoutes); | ||
| app.use("/api/admin/auth", adminAuthRoutes); |
There was a problem hiding this comment.
This line re-introduces a duplicate registration for the /api/admin/auth route, which is already defined on line 359. Please remove this duplicate to avoid potential issues with middleware and routing.
| standardHeaders: true, | ||
| legacyHeaders: false, | ||
| }); | ||
| app.use("/auth", authLimiter); |
There was a problem hiding this comment.
This rate limiter for /auth is ineffective because the application's authentication routes are prefixed with /api. This line should be removed, and the rate limiters should be applied directly to the /api/auth and /api/admin/auth routes as suggested in the other comments.
1 participant
Reverts #878