London | ITP_May_25 | Mohammad_Jafarzadeh(MR.ASH) | Form_Control

[Ashjz]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	b3290da
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/682b8828b03e940008806ada
😎 Deploy Preview	https://deploy-preview-379--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Amundeep-Dhaliwal]

Hello Ash, hope you are well.

Thank you for submitting your PR for the wireframe & form controls project. I have a few comments.

• It is really helpful that you gave a good title for the PR.
• I liked that you included a checklist for what this PR contains.
• I liked how in the form controls project the name, email, colour & size are all mandatory fields

Further improvements

• If you use [x] in your PR without any spaces the formatting should automatically use a checkbox.
• There is only one commit for this entire PR, it is a good practice to use multiple smaller commits.
• It does not look like there have been any changes to the wireframe project HTML, can we please add the description of a branch in git, link the correct pages to the Read more buttons and remove the placeholder text?

Overall this PR is a good start and I encourage you to continue your journey

[Ashjz]

still i have done everything in one commit but all done like u said :)

[Amundeep-Dhaliwal]

Hello Ash, thank you for the reply
It would be nice to edit the change list in the description.

On my side it does not look like there have been any changes to the wireframe's index.html page.

[Ashjz]

hi again wireframe is on another PR so it doesnt show on this PR.i will try to change description but this is too simple for those things!

[Amundeep-Dhaliwal]

Hello Ash, thanks for the update.
If the wire frame is on another PR, that's fine. This form control project looks good.
Good job.