Skip to content

Sheffield | 25-ITP-SEP | Declan Williams | Sprint 1 | Wireframe #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CatchingKiyoko wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Sheffield | 25-ITP-SEP | Declan Williams | Sprint 1 | Wireframe #864

CatchingKiyoko wants to merge 7 commits into from

Conversation

@CatchingKiyoko
Copy link

@CatchingKiyoko CatchingKiyoko commented Sep 27, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. added 3 sections one for each of the topics each with a link to external sites for additional explanation.
  2. updated css to add underlines to the titles.
  3. also updated css to align the 3rd section of code so no excessive margins/borders affect the page spacing.
  4. refactored the code so its easier to read.

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

@netlify
Copy link

netlify bot commented Sep 27, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1e2a3d3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68ea52926a87290008ad1f07
😎 Deploy Preview https://deploy-preview-864--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@CatchingKiyoko CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Sep 27, 2025
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

2 similar comments
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

@CatchingKiyoko CatchingKiyoko changed the title Sheffield | 25-ITP-SEP | Declan Williams | Onboarding | Wireframe Sheffield | 25-ITP-SEP | Declan Williams | Sprint 1 | Wireframe Sep 27, 2025
cjyuan
cjyuan reviewed Oct 3, 2025
View reviewed changes
Wireframe/index.html Outdated
<a href="https://www.youtube.com/embed/CbIMO5EcCD8?si=WrdQC9vvNsk98uor">A link to a short video from Codecadamy.</a>
</article>

<article id="Branch-in-GIT">
Copy link
Contributor

@cjyuan cjyuan Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixing letter case in kebab-case is not common.

Can you look up the naming convention for HTML id and class attribute values, and follow the convention?

Copy link
Author

@CatchingKiyoko CatchingKiyoko Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've looked up and changed this as its not an ideal practice to just kebab case

Wireframe/style.css Outdated
Comment on lines 108 to 121
#Branch-in-GIT {
margin-bottom: 0rem;
}

#Branch-in-GIT p {
margin: 0.5rem 0;
}

#Branch-in-GIT a {
display: inline-block;
margin-top: 0.5rem;
text-decoration: underline;
color: blue;
}
Copy link
Contributor

@cjyuan cjyuan Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why apply these styles only to the last article (the article element with this id value)?

Copy link
Author

@CatchingKiyoko CatchingKiyoko Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they was there originally because my last article would line up awkwardly and not make it look right on the webpage but after checking again now removing them they appear fine so now i removed the unnecessary lines of CSS

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025
This was referenced Oct 11, 2025
Closed
Closed
@CatchingKiyoko CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 11, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Oct 11, 2025

Changes look good

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2025
@CatchingKiyoko CatchingKiyoko mentioned this pull request Oct 11, 2025
Open
@cjyuan
Copy link
Contributor

cjyuan commented Oct 11, 2025

Follow these instructions to submit your Step 1 on the Course Platform and fill out the Trainee Application form on the Success page even though the deadline was midnight yesterday.
There is always a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CatchingKiyoko @cjyuan