Skip to content

Conversation

@CatchingKiyoko
Copy link

@CatchingKiyoko CatchingKiyoko commented Sep 27, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. added fields for name, email and size and color options
  2. added a min requirement of 2 characters for the name so can not be submitted blank
  3. added email requirement so can't be submitted blank
  4. implemented breaklines around elements so there not close together for accessibility reasons

@netlify
Copy link

netlify bot commented Sep 27, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 69602b0
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68ea5569072f5a0008202c73
😎 Deploy Preview https://deploy-preview-865--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

@CatchingKiyoko CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Sep 27, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

2 similar comments
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes)

@CatchingKiyoko CatchingKiyoko changed the title Sheffield | 25-ITP-SEP | Declan Williams | Onboarding | Form controls Sheffield | 25-ITP-SEP | Declan Williams | Sprint 2 | Form controls Sep 27, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

1 similar comment
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some minor improvement (which I missed in the previous review) you can make to further improve the code.

Can you try feeding your code to an AI tool and ask it to review the code?
Then take a look at the suggestions it gives you, and pick out the ones that actually make sense for your project. It's a great way to learn and improve your work.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025
@CatchingKiyoko CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 11, 2025
@CatchingKiyoko
Copy link
Author

i've gone through and refactored the code and made inprovements to name patterns also adding action and method attributes to tell the browser when the form is submitted and added aria labels for accessibility

@cjyuan
Copy link
Contributor

cjyuan commented Oct 11, 2025

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants