-
-
Notifications
You must be signed in to change notification settings - Fork 354
Sheffield | 25-ITP-SEP | Declan Williams | Sprint 2 | Form controls #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sheffield | 25-ITP-SEP | Declan Williams | Sprint 2 | Form controls #865
Conversation
…or better accessibility
… improved validation
…and a default option for size selection
… in a fieldset, and ensuring consistent spacing for improved readability and accessibility
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes) |
2 similar comments
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Onboarding) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some minor improvement (which I missed in the previous review) you can make to further improve the code.
Can you try feeding your code to an AI tool and ask it to review the code?
Then take a look at the suggestions it gives you, and pick out the ones that actually make sense for your project. It's a great way to learn and improve your work.
Allow hyphens and spaces in names
|
i've gone through and refactored the code and made inprovements to name patterns also adding action and method attributes to tell the browser when the form is submitted and added aria labels for accessibility |
|
Changes look good. |

Learners, PR Template
Self checklist
Changelist