Closed
Conversation
|
Version check uses string comparisons instead of semver comparison, makes it have higher risk of false matches |
Author
|
Oh, I guess then I'd have to redo the method of getting variables in dynamic instead of string and do a version of the conversion via semver, only then you might have to duplicate the converter in hscript if the user doesn't have the semver library, but I don't know. |
|
You can include the semver in the code directly just credit the original source also i recommend checking the haxe source code because it assumes its a version iirc |
|
This is peak. |
|
Fyi you need the defines macro, you might be missing it, check codename for that |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









==,!=,<=,<,>=and>.0andfalseas true.