Skip to content

Optionally adjust output card dimensions, various other fixes and changes#323

Merged
CollinHeist merged 18 commits intomasterfrom
develop
Apr 10, 2023
Merged

Optionally adjust output card dimensions, various other fixes and changes#323
CollinHeist merged 18 commits intomasterfrom
develop

Conversation

@CollinHeist
Copy link
Copy Markdown
Owner

@CollinHeist CollinHeist commented Apr 10, 2023

Major Changes

  • Optionally adjust output title card dimensions (Closes Add option to set title card dimensions #314)
    • Parse via global card_dimensions option, for example:
      options:
        card_dimensions: 1600x900
    • Technically any (positive) dimensions can be provided, but exceedingly small dimensions or those not in the 16:9
      aspect ratio are warned
    • All card types support this except the user-card types Beedman/GradientLogoTitleCard and Yozora/SlimTitleCard, which I'll partially rewrite later to implement this

Major Fixes

  • Fix svg handling in Docker
  • Fix episode text not being properly added to OlivierTitleCard
  • Utilize custom global styles for Jellyfin (Closes Use Jellyfin global styles #321)
  • Fix edge case where non-English logos could be grabbed from TMDb if they were the first logo uploaded and higher resolution than all English logos (Closes Only return English logos from TMDb #322)

Minor Changes

  • Lengthen single request timeout to 240 seconds (from 30) while syncing.
  • Log commands for failed svg to png logo conversion
  • Add fixer functionality to remove records from Emby/Jellyfin
  • Allow specification of series ID's with fixer when manually importing cards into Emby/Jellyfin
    • Created --id/--series-id argument to specify database ID's which can improve (or are required for) series matching
    • For example, importing to Emby: --id emby abcdef.. --id imdb tt1234
  • Change default global image source priority to tmdb, plex, emby, jellyfin
  • Rewrite azuravian/TitleColorMatch card type to not use intermediate images, instead using a single set of composite commands (makes card creation about 6x faster)

Minor Fixes

  • Handle yearless series when syncing from Emby

CollinHeist and others added 15 commits March 24, 2023 10:34
Log IM command history for failed SVG conversions
Some Docker containers on Windows don't have librsvg2 in IM, making SVG to PNG conversion fail. This might fix that
- because of --no-install-recommends, imagemagick-extras were excluded
- other dependencies are for ghost/post script and netbpm which might not be necessary
Update fixer --forget-cards to work with Emby and Jellyfin servers
- Add --id/--series-id fixer argument to allow specification of series ID's
- This is required for manual importing of cards into Jellyfin/Emby since they require a series ID to match (not by name as is done in Plex)
- Specified like --id emby 123 --id imdb tt1234 etc.
Set single request timeout to 240 seconds (from 30) during syncing. This is to handle slower server responses (probably caused by large libraries)
- Parse global "card_dimensions" YAML option to adjust the output dimensions of all title cards
- Currently only built in card types apply this resizing
- Implement #314

- Also change the default image source priority to tmdb, plex, emby, jellyfin
EpisodeInfo objects were not being assigned the TMDb ID's when getting episode data from TMDb, for some reason.
Adjust a lot of docstrings to the PEP8 80 character standard length
@CollinHeist
Copy link
Copy Markdown
Owner Author

CollinHeist commented Apr 10, 2023

To-Do

@CollinHeist CollinHeist merged commit 4798a2b into master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only return English logos from TMDb Use Jellyfin global styles Add option to set title card dimensions

2 participants