Add features to Tinted Frame card, many other changes and fixes#342
Merged
CollinHeist merged 57 commits intomasterfrom Jun 17, 2023
Merged
Add features to Tinted Frame card, many other changes and fixes#342CollinHeist merged 57 commits intomasterfrom
CollinHeist merged 57 commits intomasterfrom
Conversation
Use correct list of supported TMDb language codes
Might need to validate this on other machines, but the default sampling factor can be 4:2:0 on some installs, so forcing this to 4:4:4 can reduce compression artifacts for .jpg cards on some installs
Parse "episode_text_color" extra in AnimeTitleCard
For cards that support it, allow completely transparent backgrounds by setting the background color to transparent in BaseCardType.resize_output property
Implements #337. Should fix most import issues for these media servers (as well as Plex). Also update the docstrings and type annotations of a lot of methods
Change season text color in RomanNumeralTitlecard via "season_text_color" series extra
If the text elements are longer than the maximum width of the frame, rather than drawing inverted edges (starting inside going out), just do not draw that frame at all
Allow use of season and episode number format strings for logo file paths in `TintedFrameTitleCard`
Handle combined ISO-639-1 and ISO-3166-1 language codes like "es-MX" or "es-ES" for greater translation fidelity
- Change episode text color to default to the font color - Parse "middle_element", default to "omit" but can be "logo" to add an enlarged logo to the middle of the frame - Parse "logo_size" as a scalar for shrinking or enlarging the logo size - Parse "blur_edges" boolean to optionally enable/disable blurring the outer frame edges #341 - Change vertical position of the top logo element +20 px
Catch and reset DB for uncaught ValueError from PersistentDatabase function calls
Catch and log (at the Manager level) uncaught Exceptions in Serial run mode
Increase timeout to 600 sec (from 30) to handle slow Sonarr connections
Handle/reject <Code>AccessDenied</Code> image content from Plex
Owner
Author
To-Do
|
- Because these media servers require per-Episode ID's to match content each run, Episode ID assignment should occur for all Episodes, not just those with missing content. This only affects Shows whose primary media server is Emby or Jellyfin. - Also add better type annotations in a many places
Was using TVDB ID's
Implements #348, also adds some TA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major Changes
es-MXores-ESfor greater translation fidelitymiddle_elementextra - can be eitherlogooromit- to add enlarged logo to the middle of the card, e.g.:logo_sizeextra to allow shrinking or enlarging the logo size by a scalar, for example:logo_size: 1.5to scale to 150%blur_edgesextra to optionally enable/disable blurring the outer edgeMajor Fixes
Managerlevel) uncaught Exceptions in serial run modeMinor Changes
episode_text_colorextraseason_text_colorextra4:4:4sampling factor in all card operations (can default to4:2:0which has some JPEG compression artifacts)omit_logoYAML option in season poster config--season-posterargument inmini_makerto--season-poster SOURCE DESTINATION, add--season-poster-logoargumenthide_episode_textto Fade title cardRemoteFiledownload errorsMinor Fixes
""database ID's inDatabaseInfoContainerclasstemplatesspecification(s)ValueErrorfromPersistentDatabasefunction calls<Code>AccessDenied</Code>)