Skip to content

Remove code comments on TypeScript compilation process#5953

Closed
dfsmania wants to merge 1 commit intoColorlibHQ:masterfrom
dfsmania:remove_comments_from_ts_compilation
Closed

Remove code comments on TypeScript compilation process#5953
dfsmania wants to merge 1 commit intoColorlibHQ:masterfrom
dfsmania:remove_comments_from_ts_compilation

Conversation

@dfsmania
Copy link
Copy Markdown
Contributor

@dfsmania dfsmania commented Dec 24, 2025

Remove comments on the compilation process of TypeScript code. This only affects the generated adminlte.js file, as the minimized adminlte.min.js already handles this.

  • Comments are useful only for maintenance, on source files, there's no benefit on having them on the compiled adminlte.js distribution file.
  • This also reduces the compiled file sizes.

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 24, 2025 •
edited
Loading

✅ Deploy Preview for adminlte-v4 ready!

Name Link
🔨 Latest commit ecd65d3
🔍 Latest deploy log https://app.netlify.com/projects/adminlte-v4/deploys/694c2e923d3aac0008f91141
😎 Deploy Preview https://deploy-preview-5953--adminlte-v4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dfsmania dfsmania mentioned this pull request Dec 24, 2025
Closed
@puikinsh
Copy link
Copy Markdown
Member

puikinsh commented Mar 10, 2026

Thanks @dfsmania! Merged this into master (commit 68e95c1). The unminified adminlte.js dropped by ~15% — nice cleanup. 👍

@puikinsh puikinsh closed this Mar 10, 2026
puikinsh added a commit that referenced this pull request Mar 10, 2026
@puikinsh @dfsmania @claude
chore: remove comments from compiled TypeScript output (#5953)
68e95c1 
Add removeComments to tsconfig.json so adminlte.js strips source
comments. Reduces unminified bundle by ~15%. Minified output unaffected.

Based on PR #5953 by @dfsmania.

Co-Authored-By: Diego Smania <diego.smania@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dfsmania dfsmania deleted the remove_comments_from_ts_compilation branch March 10, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dfsmania @puikinsh