fix: apply nav-indent left padding correctly#6001
Merged
puikinsh merged 1 commit intoColorlibHQ:masterfrom Mar 18, 2026
Merged
Conversation
❌ Deploy Preview for adminlte-v4 failed.
|
Member
|
Thanks @Kneemund! Great catch on the selector scoping — the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest version of AdminLTE v4 (rc7), the
nav-indentbehaves unexpectedly. The SCSS selector.nav-indent &is compiled to.nav-indent .sidebar-menu .nav-treeview.That means that you would have to apply
nav-indentto a parent of the sidebar menu (e.g. the sidebar wrapper), which is very unintuitive compared to the other nav classes.In compact mode, the selector for the equivalent rule is simply
.nav-compact.nav-indent .nav-treeview, which means that.nav-indentworks differently (and as expected) there.This PR makes the problematic non-compact mode rule behave the same as the other
nav-indentrules.