Skip to content

fix: consistent sidebar style#6003

Merged
puikinsh merged 1 commit intoColorlibHQ:masterfrom
Kneemund:fix-sidebar-colors
Mar 18, 2026
Merged

fix: consistent sidebar style#6003
puikinsh merged 1 commit intoColorlibHQ:masterfrom
Kneemund:fix-sidebar-colors

Conversation

@Kneemund
Copy link
Copy Markdown
Contributor

Currently, nested links look different than top level links, which is especially noticeable when using custom sidebar colors. This PR makes the sidebar style more consistent, mostly by expanding the style of nested links onto top level links.

Here are a few of the inconsistencies in the old version fixed by this PR:

  • Hovering over active top level links overrides the active colors with the hover colors. This does not happen with nested links.
  • Focusing nested links does not apply the hover background color. This does happen with top level links.
  • Open menus that are not active look weird, as they have the normal background but the hover text color. Because the SCSS rule explicitly sets the hover background color to transparent, it messes up the focus state (since that reuses the hover colors).

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 17, 2026

Deploy Preview for adminlte-v4 failed.

Name Link
🔨 Latest commit 91d868c
🔍 Latest deploy log https://app.netlify.com/projects/adminlte-v4/deploys/69b97520b650e60008c6c91e

@puikinsh
Copy link
Copy Markdown
Member

Thanks again @Kneemund! Really appreciate you taking the time to untangle the sidebar color specificity issues — the hover/active/focus inconsistencies between top-level and nested links have been bugging us. The simplified selectors are much cleaner. Merging this as well. 🙏

@puikinsh puikinsh merged commit 637cf16 into ColorlibHQ:master Mar 18, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants