psi: parse PMT packets with multiple sections#75
Merged
ieckart merged 4 commits intoComcast:masterfrom Jun 12, 2018
Merged
Conversation
Contributor
Author
|
Here's a real world sample where multiple table sections are provided in a single packet, and the first section is not the PMT: https://s3.amazonaws.com/tmm1/combined-pmt-tids.ts I recently fixed a similar bug in ffmpeg's mpegts parser. You can read more about the issue here: http://ffmpeg.org/pipermail/ffmpeg-devel/2018-May/229803.html |
Contributor
Author
|
I have several more PRs I'd like to send with PMT parsing enhancements, but they would cause merge conflicts with this one so I've held off for now. Would love to see this PR merged soon. |
Contributor
Author
|
Any objections here? |
Collaborator
|
@ieckart Can I get another set of eyes here, please? |
Collaborator
|
looks good to me. Reviewed the code, ran the tests, and did an integration test make sure it didn't break compatibility. |
ieckart
approved these changes
Jun 12, 2018
This was referenced Jun 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #74