Skip to content

psi: parse PMT packets with multiple sections#75

Merged
ieckart merged 4 commits intoComcast:masterfrom
tmm1:pmt-multiple-sections
Jun 12, 2018
Merged

psi: parse PMT packets with multiple sections#75
ieckart merged 4 commits intoComcast:masterfrom
tmm1:pmt-multiple-sections

Conversation

@tmm1
Copy link
Contributor

@tmm1 tmm1 commented May 11, 2018

fixes #74

@tmm1
Copy link
Contributor Author

tmm1 commented May 11, 2018

Here's a real world sample where multiple table sections are provided in a single packet, and the first section is not the PMT: https://s3.amazonaws.com/tmm1/combined-pmt-tids.ts

I recently fixed a similar bug in ffmpeg's mpegts parser. You can read more about the issue here: http://ffmpeg.org/pipermail/ffmpeg-devel/2018-May/229803.html

@tmm1
Copy link
Contributor Author

tmm1 commented May 15, 2018

I have several more PRs I'd like to send with PMT parsing enhancements, but they would cause merge conflicts with this one so I've held off for now. Would love to see this PR merged soon.

@tmm1
Copy link
Contributor Author

tmm1 commented Jun 11, 2018

Any objections here?

@guygrigsby
Copy link
Collaborator

@ieckart Can I get another set of eyes here, please?

@ieckart
Copy link
Collaborator

ieckart commented Jun 12, 2018

looks good to me. Reviewed the code, ran the tests, and did an integration test make sure it didn't break compatibility.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2018

CLA assistant check
All committers have signed the CLA.

@ieckart ieckart self-requested a review June 12, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PSI interface and PMT parser assume single "Program Map" section

5 participants