Updated LoginButton events to respond to GlobalProvider#115
Merged
shweaver-MSFT merged 4 commits intodev/7.1.0from Jul 12, 2021
Merged
Updated LoginButton events to respond to GlobalProvider#115shweaver-MSFT merged 4 commits intodev/7.1.0from
shweaver-MSFT merged 4 commits intodev/7.1.0from
Conversation
…esponse to the GlobalProvider
|
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the Login/Logout-Completed events on LoginButton only fire when actually interacting with the button. This can make it difficult to use the LoginButton events reliably, since they won't fire if the GlobalProvider is updated directly.
What is the new behavior?
The new behavior allows the LoginButton to emit Login/Logout-Completed events in response to state changes in the GlobalProvider. When the GlobalProvider state changes, the LoginButton will emit those events as appropriate.
Note: The Login/Logout-Initiated events will not fire. This is because we have limited ability to understand the login flow based on the ProviderState enum values, SignedIn, SignedOut, and Loading.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information