[BUG] Popup V2 within NavigationPage

[reid-kirkpatrick]

Is there an existing issue for this?

• I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

• I have read the "Reporting a bug" section on Contributing file: https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md#reporting-a-bug

Current Behavior

Popups shown when a NavigationPage is present don't show properly

screencapture-1754069610768.mp4

Expected Behavior

The popup should show as any other time, with no background and no additional navigation bar (with back button)

Steps To Reproduce

1. Open and run linked repro project
2. Tap the "Open Popup" button and observe the expected behavior
3. Tap anywhere to dismiss
4. Tap the "Open Modal" button to open a NavigationPage
5. Tap the "Open Popup" button to observe the undesired behavior

Link to public reproduction project repository

https://github.com/reid-kirkpatrick/PopupTest

Environment

- .NET MAUI CommunityToolkit: 12.1.0
- OS: Android / iOS
- .NET MAUI: 9.0.81 / 9.0.90

Anything else?

No response

[reid-kirkpatrick]

Is this supported, or every planned to be supported? Is there a better way to accomplish having a modal with it's own navigation hierarchy without using a NavigationPage that would be compatible with the new popups?

[JanmarlPaulRodriguez]

We can't ship new updates because of this issue. It was working previously.

[albyrock87]

If you're using Nalu for navigation check this out: https://nalu-development.github.io/nalu/layouts.html#popups

If you're not, you can work this around by subclassing toolkit:Popup and override protected override void OnHandlerChanging(HandlerChangingEventArgs args).

In that method you can do:

if (Parent?.Parent is ContentPage popupPage) {
    NavigationPage.SetHasNavigationBar(popupPage, false);
    // Do all the changes you need to do on the page level, i.e. setting the background to transparent
}

[brendonupson]

Same for me. Cannot close a popup from a modal:
An unhandled exception of type 'CommunityToolkit.Maui.Views.PopupNotFoundException' occurred in Microsoft.iOS.dll: 'Unable to close popup: could not locate PopupPage. ShowPopup or ShowPopupAsync must be called before CloseAsync. If using a custom implementation of Popup, override the CloseAsync method'

========
at CommunityToolkit.Maui.Views.PopupPage.CloseAsync(PopupResult result, CancellationToken token) in /_/src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs:line 87

....somewhere around here:
var popupPageToClose = Navigation.ModalStack.OfType().LastOrDefault(popupPage => popupPage.Content == Content);

if (popupPageToClose is null)
{
throw new PopupNotFoundException();
}

[dainius-r]

I experience same issue as @brendonupson
@bijington is there any plans for fixing or know workaround how to use popup from modal page?

[tritter]

I also have problems when you create NavigationPages inside the Shell. It all worked before now it's a mess with the new popups. Sometimes the views are broken, invisible not overlapping or overlapping. It was already a workaround before to use NavigationPages inside the AppShell. I have the feeling this is completely unsupported. But there are use cases that require multiple NavigationPages.

[pictos]

I also have problems when you create NavigationPages inside the Shell.

@tritter why are you creating navigation pages with Shell? I'm almost sure it's an anti-pattern

[dainius-r]

@pictos please see this MAUI issue: dotnet/maui#15498
It seams that @PureWeen suggested to use NavigationPage in this case, if it's anti-pattern then, MAUI has unresolved bug?
The case is we like to use shell ToolbarItems and TitleView in our modal pages, but also like to use Popup, how can we achieve both?

[pictos]

@dainius-r for sure Shane knows better than me about Shell, but from my interpretation, his suggestion was a workaround/test. If you see there's a linked PR to that issue (the one that closes the issue), that improves modal navigation on Shell. From what I see, the fix is to not need to use a NavigationPage.

But I'm happy to be wrong. As I said, I'm almost sure about it.

update: As I guessed (from a vague memory fragment), Shell uses NavigationPage for modal navigation under the hood. So wrapping another NavigationPage will not solve the issue.

[nikamvd]

@pictos Is there any way to apply your fix (#2919) while using the current CommunityToolkit.Maui version 12.3.0 until the fix gets released in a newer version? My project heavily relies on showing modal pages wrapped inside navigation pages, which I can't change at this moment due to the amount of refactoring that will be needed.