Add drawing started, cancelled, and on-drawing commands#1440
Add drawing started, cancelled, and on-drawing commands#1440TheCodeTraveler merged 14 commits intomainfrom
Conversation
This commit adds the following changes: - Added `DrawingStartedCommand` to handle the event when drawing starts. - Added `DrawingCancelledCommand` to handle the event when drawing is cancelled. - Added `OnDrawingCommand` to handle the event while drawing. These changes allow for better control and handling of the drawing events in the `DrawingViewPage.xaml` and `DrawingViewViewModel.cs`.
- Renamed `DrawingStarted` to `OnDrawingStarted` - Renamed `DrawingCancelled` to `OnDrawingCancelled` These changes were made to improve consistency and clarity in the code.
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks Vlad!!
Could you add the docs for the new APIs? I went ahead and added the
approved
I'd love for us to publish v6.1.0 this week before our standup! So if you're able to submit a Docs PR either tomorrow or Wednesday, we can merge this in for v6.1.0 which'll be our final release before .NET 8!!
I went ahead and implemented the new IDrawingView.OnDrawingLineCompleted(IDrawingLine) API implementing it as a Default Interface Implementation. This avoids breaking changes to our users while still allowing us to implement the new API under the hood. This'll make our lives easier when we remove the Obsolete API in a future PR.
/// <summary>
/// Event occurred when drawing line completed
/// </summary>
/// <param name="lastDrawingLine">Last drawing line</param>
void OnDrawingLineCompleted(IDrawingLine lastDrawingLine) => OnDrawingLineCompleted(lastDrawingLine);
/// <summary>
/// Event occurred when drawing line completed
/// </summary>
/// <param name="lastDrawingLine">Last drawing line</param>
[Obsolete($"Use {nameof(OnDrawingLineCompleted)} instead.")]
void DrawingLineCompleted(IDrawingLine lastDrawingLine);|
@brminnick documentation PR is ready |
This commit adds the following changes:
DrawingStartedCommandto handle the event when drawing starts.DrawingCancelledCommandto handle the event when drawing is cancelled.OnDrawingCommandto handle the event while drawing.These changes allow for better control and handling of the drawing events in the
DrawingViewPage.xamlandDrawingViewViewModel.cs.Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information