Skip to content

Improve Windows sample app UI#1861

Merged
TheCodeTraveler merged 10 commits into
CommunityToolkit:mainfrom
mhrastegari:1860-Improve-sample-app-on-windows
Jun 20, 2024
Merged

Improve Windows sample app UI#1861
TheCodeTraveler merged 10 commits into
CommunityToolkit:mainfrom
mhrastegari:1860-Improve-sample-app-on-windows

Conversation

@mhrastegari
Copy link
Copy Markdown
Contributor

Description of Change

Changing Shell Flyout behavior and style on WinUI version of sample app

Linked Issues

PR Checklist

  • Has a linked Issue/Discussion and has been `approved
  • Rebased on top of main at time of PR

Additional information

New look:

Dark:

Screenshot (30)

Light:

Screenshot (31)

@jfversluis
Copy link
Copy Markdown
Member

This is amazing @mhrastegari thank you so much! One very much nitpicky thing... The space between the "cards" on the right seems a bit much? I feel it could look even a little bit better even if that was a bit less? But I am in no way a designer so maybe I'm very wrong too 😄

@mhrastegari
Copy link
Copy Markdown
Contributor Author

mhrastegari commented May 6, 2024

Oh you mean their vertical spacing?

@jfversluis
Copy link
Copy Markdown
Member

I mean this

image

@mhrastegari
Copy link
Copy Markdown
Contributor Author

Yeah agreed 👍🏻🚀
I'll fix it now

Copy link
Copy Markdown
Collaborator

@TheCodeTraveler TheCodeTraveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good!! Thanks @mhrastegari!

@TheCodeTraveler TheCodeTraveler enabled auto-merge (squash) June 20, 2024 21:48
@TheCodeTraveler TheCodeTraveler merged commit a05175d into CommunityToolkit:main Jun 20, 2024
@mhrastegari mhrastegari deleted the 1860-Improve-sample-app-on-windows branch June 21, 2024 08:24
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants