Enhance service lifecycle and exit strategy#2039
Merged
jfversluis merged 15 commits intoCommunityToolkit:mainfrom Aug 16, 2024
Merged
Enhance service lifecycle and exit strategy#2039jfversluis merged 15 commits intoCommunityToolkit:mainfrom
jfversluis merged 15 commits intoCommunityToolkit:mainfrom
Conversation
- Updated `AndroidManifest.xml` to improve `CommunityToolkit.Maui.Media.Services` behavior. Added `android:stopWithTask=true` and `android:foregroundServiceType=mediaPlayback` attributes to ensure the service stops with the task and properly manages media playback in the foreground. - Added `OnDestroy()` method in `MediaControlsService.android.cs` for a more aggressive shutdown approach. This includes logging service destruction, stopping and removing the service from the foreground, finishing and removing the task, exiting the application, and ensuring base class cleanup with `base.OnDestroy()`. This aims at a cleaner exit and resource management when the service is destroyed.
2 tasks
pictos
reviewed
Aug 5, 2024
src/CommunityToolkit.Maui.MediaElement/Services/MediaControlsService.android.cs
Show resolved
Hide resolved
jfversluis
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
AndroidManifest.xmlto improveCommunityToolkit.Maui.Media.Servicesbehavior. Addedandroid:stopWithTask=trueandandroid:foregroundServiceType=mediaPlaybackattributes to ensure the service stops with the task and properly manages media playback in the foreground.OnDestroy()method inMediaControlsService.android.csfor a more aggressive shutdown approach. This includes logging service destruction, stopping and removing the service from the foreground, finishing and removing the task, exiting the application, and ensuring base class cleanup withbase.OnDestroy(). This aims at a cleaner exit and resource management when the service is destroyed.AndroidDestroyBug.mp4
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR