Skip to content

[Sample App] Add <UseMaui>true</UseMaui>#2057

Merged
TheCodeTraveler merged 1 commit into
CommunityToolkit:mainfrom
ne0rrmatrix:FixBuildingSampleProject
Jul 24, 2024
Merged

[Sample App] Add <UseMaui>true</UseMaui>#2057
TheCodeTraveler merged 1 commit into
CommunityToolkit:mainfrom
ne0rrmatrix:FixBuildingSampleProject

Conversation

@ne0rrmatrix
Copy link
Copy Markdown
Member

  • Bug fix

Description of Change

Revert removal of <UseMaui>true<</UseMaui> in sample csproj

Linked Issues

PR Checklist

Additional information

Fixes cannot build and/or run on any device/emulator.

@ne0rrmatrix ne0rrmatrix changed the title Revert removal of `<UseMaui>true</UseMaui> Revert removal of <UseMaui>true</UseMaui> Jul 24, 2024
@VladislavAntonyuk
Copy link
Copy Markdown
Contributor

Should it only be reverted for Sample project or all projects?

@filipnavara
Copy link
Copy Markdown
Contributor

Should it only be reverted for Sample project or all projects?

Libraries should not need it. UseMaui is somewhat misleadingly deprecated since .NET 8 with a warning (the warning message is incorrect though: dotnet/maui#20658).

@GeorgeLeithead
Copy link
Copy Markdown
Contributor

Should it only be reverted for Sample project or all projects?

Libraries should not need it. UseMaui is somewhat misleadingly deprecated since .NET 8 with a warning (the warning message is incorrect though: dotnet/maui#20658).

I gave it all a try from a fresh clone (with a restore and workload restore). Without the UseMaui in the libraries, it all works perfectly fine as long as the "actual" MAUI project (in this case "Sample") has the UseMaui, as indicated by @filipnavara.

I also ran all of the Unit Tests, and they pass with 100%.

@TheCodeTraveler TheCodeTraveler changed the title Revert removal of <UseMaui>true</UseMaui> [Sample App{ Add <UseMaui>true</UseMaui> Jul 24, 2024
@TheCodeTraveler TheCodeTraveler enabled auto-merge (squash) July 24, 2024 15:57
@TheCodeTraveler TheCodeTraveler changed the title [Sample App{ Add <UseMaui>true</UseMaui> [Sample App] Add <UseMaui>true</UseMaui> Jul 24, 2024
@TheCodeTraveler TheCodeTraveler merged commit 0d49ae0 into CommunityToolkit:main Jul 24, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Community toolkit project cannot build sample project

5 participants