Move permissions from sample android manifest to Media Element#2500
Merged
TheCodeTraveler merged 2 commits intoCommunityToolkit:mainfrom Feb 10, 2025
Merged
Conversation
…ctly from MediaElement. This will allow us to automatically generate the required permission in any app and remove the need for developers to add them. Updating the documention to reflect changes will be needed.
pictos
approved these changes
Feb 10, 2025
Member
Author
|
Documentation Has been added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This will remove the need for developers to add any permissions beyond the basic network state and any app specific permissions they need. Media Element will add permissions directly as xml fragments to android manifest. This will allow us to add them during build process and no longer require users to add them manually. We have had a number of developers who have had issues with setting them. We have a few bug reports where adding the required permissions fixes the issues listed.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Documentation will need to be updated to reflect changes. We will no longer require users to add permissions for media element. It will be generated automatically. Link to discussion: #2437