Fix DateTimeOffset Converter #2582#3077
Merged
VladislavAntonyuk merged 4 commits intomainfrom Feb 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DateTimeOffsetConverter so ConvertBackTo computes the UTC offset based on the provided DateTime (so DST/seasonal offsets are correct), addressing #2582.
Changes:
- Updated
DateTimeOffsetConverter.ConvertBackToto useTimeZoneInfo.*.GetUtcOffset(value)instead of current-time offsets. - Updated unit tests to validate offsets and to include offset in
DateTimeOffsetcomparisons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/CommunityToolkit.Maui/Converters/DateTimeOffsetConverter.shared.cs | Computes offsets from the parameter DateTime to fix DST-dependent conversions. |
| src/CommunityToolkit.Maui.UnitTests/Converters/DateTimeOffsetConverterTests.cs | Adjusts expected offsets and comparer to validate correct offset behavior (but includes environment-dependent cases). |
src/CommunityToolkit.Maui.UnitTests/Converters/DateTimeOffsetConverterTests.cs
Show resolved
Hide resolved
src/CommunityToolkit.Maui.UnitTests/Converters/DateTimeOffsetConverterTests.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.UnitTests/Converters/DateTimeOffsetConverterTests.cs
Show resolved
Hide resolved
src/CommunityToolkit.Maui.UnitTests/Converters/DateTimeOffsetConverterTests.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Instead of using current date time offset, we need to use offset of the parameter date
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information