Fix: [BUG] StatusBar too large in landscape mode (in API 36+) #3170#3182
Open
Pastajello wants to merge 2 commits intoCommunityToolkit:mainfrom
Open
Fix: [BUG] StatusBar too large in landscape mode (in API 36+) #3170#3182Pastajello wants to merge 2 commits intoCommunityToolkit:mainfrom
Pastajello wants to merge 2 commits intoCommunityToolkit:mainfrom
Conversation
Pastajello
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
So, the issue here is that height in Android 36 is different for "status_bar_height" resource that is used for the status bar height. Funnily, the status_bar_height is now the "status_bar_height" / screen density and can be fixed as such.
There is also a second option - I guess more correct one, to use RootWindowInsets.GetInsets(WindowInsets.Type.StatusBars()).Top - think this will take into account whatever notch someone may create.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal) - issue was created 2 days ago, I think it was not yet checked.mainat time of PRAdditional information
For now I've created this PR as a suggestion. I'm still reading how to properly create+style etc. the PR.