Fixed an issue building sample projects on macOS #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlodotexe
added
bug 🐛
michael-hawker
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug was that introduced in #61 and found during investigation of CommunityToolkit/Windows#152.
Did a binary search on the git history to find where this started. The issue would have been showing earlier if not for the bug we fixed in this PR.
The tfms just weren't getting enabled in CI because of this bug. I fixed it that commit, then it uncovered this issue we're having. I continued rewinding git in a binary search and manually applied the fix over it as I went to find where the problem was introduced.
This issue stops if you rewind before this PR and manually apply the bugfix linked above, meaning that PR is the cause of the issue.
From that PR:
Well... the Roslyn ticket I linked was for .NET Core. We're still on xamarin for MacOS. We have a NET 7 branch ready to go, but we aren't ready to commit to dropping Xamarin just yet (maybe soon?).
For now, we'll just remove this ProjectReference on MacOS.