Skip to content

add connector list map to check connector info#67

Merged
ssicard merged 2 commits intomainfrom
ss/cache-connector-validations
Apr 7, 2025
Merged

add connector list map to check connector info#67
ssicard merged 2 commits intomainfrom
ss/cache-connector-validations

Conversation

@ssicard
Copy link
Copy Markdown
Contributor

@ssicard ssicard commented Apr 4, 2025

Description

Addresses a comment on a previous PR by creating a cache of connectors from which to query information.

Improvements:

  • moves context creation into main
  • queries https://conduit.io/connectors.json to get a list of all connectors and most recent versions. This removes the need to query github.com
  • creates test_helper.go in Validator for use by consuming packages

Fixes # (issue)

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@ssicard ssicard marked this pull request as ready for review April 4, 2025 18:21
@ssicard ssicard requested a review from a team as a code owner April 4, 2025 18:21
@ssicard ssicard merged commit 473e7e1 into main Apr 7, 2025
4 checks passed
@ssicard ssicard deleted the ss/cache-connector-validations branch April 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants