Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

upd(mox:input): update light mode UI for input fields#128

Merged
jayjayjpg merged 3 commits into
mainfrom
jj/inputs-with-boundaries
Jul 21, 2023
Merged

upd(mox:input): update light mode UI for input fields#128
jayjayjpg merged 3 commits into
mainfrom
jj/inputs-with-boundaries

Conversation

@jayjayjpg
Copy link
Copy Markdown
Contributor

@jayjayjpg jayjayjpg commented Jul 20, 2023

Part of https://github.com/meroxa/platform-ui-v1/issues/1029

This reduces the brightness of some colors used within the Mox::Input component and Mox::Link in order to improve the elements' contrast on light backgrounds. This way, we can write automated accessibility tests for the work of https://github.com/meroxa/auth0-templates/issues/210

Screens

Input Fields

light mode dark mode
input-light-mode input-dark-mode

Links

light mode dark mode
Screenshot 2023-07-21 at 1 13 06 PM Screenshot 2023-07-21 at 1 13 18 PM

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 20, 2023

🦋 Changeset detected

Latest commit: 325979b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mx-ui-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Test coverage: 92.49%

🚨 No before coverage could be loaded

@jayjayjpg jayjayjpg force-pushed the jj/inputs-with-boundaries branch from 314fd4e to 2d3a71c Compare July 21, 2023 09:08
@jayjayjpg jayjayjpg marked this pull request as ready for review July 21, 2023 09:13
@github-actions
Copy link
Copy Markdown
Contributor

Test coverage: 92.49%

🤷‍♂️ Did not change

@github-actions
Copy link
Copy Markdown
Contributor

Test coverage: 92.49%

🤷‍♂️ Did not change

@jayjayjpg jayjayjpg force-pushed the jj/inputs-with-boundaries branch from 73777dc to 325979b Compare July 21, 2023 10:42
@github-actions
Copy link
Copy Markdown
Contributor

Test coverage: 92.49%

🤷‍♂️ Did not change

@jayjayjpg jayjayjpg merged commit baa753d into main Jul 21, 2023
@jayjayjpg jayjayjpg deleted the jj/inputs-with-boundaries branch July 21, 2023 14:50
@meroxa-machine meroxa-machine mentioned this pull request Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants