Fix variable name for $Credit_Payment_instructions#437
Merged
oriol merged 1 commit intoConnectingEurope:masterfrom Jun 14, 2025
Merged
Conversation
The use of the variable has a space after the name, while the definition does not. This results in the variable not being expanded when using the Schematron Skeleton implementation, and thus in an xlst file that can't be loaded. It would probably make more sense to remove the space, but for consistency with the rest of the variables i've added it, rather than remove the one where the variable is used.
tjeb
added a commit
to peppolautoriteit-nl/validation
that referenced
this pull request
Jun 6, 2025
This is a backport of the suggested fix submitted here: ConnectingEurope/eInvoicing-EN16931#437
Collaborator
|
@oriol this is a critical issue. Do we plan to release a hotfix for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of the variable has a space after the name, while the definition does not. This results in the variable not being expanded when using the Schematron Skeleton implementation, and thus in an xlst file that can't be loaded.
It would probably make more sense to remove the space, but for consistency with the rest of the variables i've added it, rather than remove the one where the variable is used.