Merged
Conversation
|
📦 📦 |
|
📦 📦 |
ivokub
approved these changes
Dec 21, 2023
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
Conditional accept - I do not have enough knowledge about FFTs and twiddles to understand if done correctly. But making the computation optional seems correct.
If not urgent then I would ask @ThomasPiellard to confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short, this PR allows for
fft.NewDomain()to have an optionfft.WithoutPrecompute()which initializes the domain without precomputing (all) twiddles & coset tables.For large domains, this save a huge amount of memory at the cost of 20-30% CPU perf downgrade.
To simplify code, it modifies existing inner DIF and DIT fft methods to take a precomputed twiddle table and a starting stage; so twiddles can still be precomputed but we skip the first stages (each stage we skip we save domain.Cardinality / stage*2 memory).