Merged
Conversation
12 tasks
yelhousni
approved these changes
Oct 31, 2024
Collaborator
yelhousni
left a comment
There was a problem hiding this comment.
I reviewed bls12-377 and the code-generated part. The other curves should be similar. I can tell it follows the paper, the spec and the reference implementation. I am not confident on my understanding on the linear layer analysis (https://tosc.iacr.org/index.php/ToSC/article/view/8913/8489) but as I said it follows the spec and other implementations so it should be good. t>=4 cases are yet to be merged here or pushed in a different PR but this one is good to go. Only one remark the Sbox can be code-generated per curve/field as in MiMC to make the code simpler. We need also to add poseidon2 to hash/hashes.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation of poseidon2 for t=2,3 following
reference implementation
reference paper
TBD: algos 1, 2, 3 of https://tosc.iacr.org/index.php/ToSC/article/view/8913/8489 for finding internal matrices when t>3
Type of change
Please delete options that are not relevant.
How has this been benchmarked?
Please describe the benchmarks that you ran to verify your changes.
goarch: amd64
pkg: github.com/consensys/gnark-crypto/ecc/bn254/fr/poseidon2
cpu: Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
BenchmarkPoseidon2-12 163784 7035 ns/op
Checklist:
golangci-lintdoes not output errors locally