bug: binary decomposition of a variable is not strictly asserted to be less than the modulus

[lightning-li]

Description

The bugfix for issue #836 isn't complete. It seems the line https://github.com/Consensys/gnark/blob/master/std/math/bits/conversion_binary.go#L100C13-L100C13 used wrong parameters. It should be cmper.MustBeLessOrEqCst(bits, bound, v)

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

Context

Your Environment

• gnark version used (e.g. v0.8.1, HEAD@develop):
• gnark-crypto version used:
• go version (e.g. 1.20.6):
• Operating System and version:

[ivokub]

Hmm, looking at it I think it should actually be field modulus + 1. I will have a look at it and update your PR accordingly.

Thanks for letting know, somehow I missed that I was doing LessEq against constant not Less.