fix: Decompressor to return -1 when output doesn't fit#1022
Merged
Conversation
AlexandreBelling
approved these changes
Jan 26, 2024
Collaborator
AlexandreBelling
left a comment
There was a problem hiding this comment.
Looking good to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the output buffer
dis not long enough to contain the decompressed stream,DecompressreturnsdLength = 0which is seen as a valid output. This PR changes that to -1 which in any cryptographic prime-order field is so large it cannot be confused with a valid output length.Type of change
How has this been tested?
TestOutBufTooShortHow has this been benchmarked?
No benchmark. Performance impact expected to be negligible.
Checklist:
golangci-lintdoes not output errors locally