Skip to content

refactor: separate the fixed circuits for ECPairing used in zkevm#1217

Merged
ivokub merged 1 commit intomasterfrom
refactor/ecpair-integration
Jul 23, 2024
Merged

refactor: separate the fixed circuits for ECPairing used in zkevm#1217
ivokub merged 1 commit intomasterfrom
refactor/ecpair-integration

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented Jul 23, 2024

Description

In zkevm we use three separate circuits for efficiency (documented in zkevm repository).

Depends on #1209.

Type of change

  • Refactor, non-breaking

How has this been tested?

In downstream usage

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added type: consolidate strengthen an existing feature dep: linea Issues affecting Linea downstream priority: P1-high Issue priority: high labels Jul 23, 2024
@ivokub ivokub requested a review from yelhousni July 23, 2024 10:11
@ivokub ivokub self-assigned this Jul 23, 2024
Copy link
Copy Markdown
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the renamings in 4013404

@ivokub ivokub force-pushed the refactor/ecpair-integration branch from b31dc61 to acef38b Compare July 23, 2024 11:20
@ivokub
Copy link
Copy Markdown
Collaborator Author

ivokub commented Jul 23, 2024

Thanks. Rebased and renamed. Will wait for CI and then merge.

@ivokub ivokub merged commit 7087cd0 into master Jul 23, 2024
@ivokub ivokub deleted the refactor/ecpair-integration branch July 23, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep: linea Issues affecting Linea downstream priority: P1-high Issue priority: high type: consolidate strengthen an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants