feat add random mask to groth16 commitment#1245
Merged
Conversation
Contributor
Author
|
@ivokub |
ivokub
reviewed
Aug 22, 2024
Collaborator
I made the test to expect provers success instead. It can be useful in the future to catch regressions. I think it is useful that we can have prover assigned random commitment if we don't commit to anything. |
ivokub
approved these changes
Aug 22, 2024
Collaborator
ivokub
left a comment
There was a problem hiding this comment.
I think it makes all sense! I added a regression test also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a random mask to the BSB22 commitments in order to make them hiding.
It is achieved simply by randomizing a new variable and adding it to the commitment.
Type of change
Checklist:
golangci-lintdoes not output errors locally