Skip to content

refactor: use strings.ReplaceAll#1257

Merged
ivokub merged 1 commit into
Consensys:fix/typosfrom
bytetigers:master
Aug 30, 2024
Merged

refactor: use strings.ReplaceAll#1257
ivokub merged 1 commit into
Consensys:fix/typosfrom
bytetigers:master

Conversation

@bytetigers
Copy link
Copy Markdown
Contributor

@bytetigers bytetigers commented Aug 23, 2024

Description

use strings.ReplaceAll

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • Test A
  • Test B

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bytetigers
refactor: use strings.ReplaceAll
4200fb8 
Signed-off-by: bytetigers <bytetiger@icloud.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub added the type: typo Fixes typos in comments or documentation label Aug 30, 2024
@ivokub ivokub changed the base branch from master to fix/typos August 30, 2024 08:00
ivokub
ivokub approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivokub ivokub merged commit 546848b into Consensys:fix/typos Aug 30, 2024
ivokub added a commit that referenced this pull request Aug 30, 2024
@ivokub @bytetigers
@highcloudwind @shuriu @fivecut @Pan-chao
fix: several external typo fixes (#1261)
c59881d 
* refactor: use strings.ReplaceAll (#1257)

* chore: fix some function names (#1240)

Signed-off-by: highcloudwind <highcloud@aliyun.com.>
Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>

* fix: fix most typos (#1185)

* fix: fix most typos

* fix: update template

---------

Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>

* chore: make function comment match function names (#1168)

Signed-off-by: fivecut <fivecut@126.com>

* chore(std): some proofreading (#1001)

* err msg

* emulated field

* bounded

---------

Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>

---------

Signed-off-by: highcloudwind <highcloud@aliyun.com.>
Signed-off-by: fivecut <fivecut@126.com>
Co-authored-by: bytetigers <bytetiger@icloud.com>
Co-authored-by: highcloudwind <highcloud@aliyun.com>
Co-authored-by: shuriu <161208801+shuriu@users.noreply.github.com>
Co-authored-by: fivecut <fivecut@126.com>
Co-authored-by: Pan chao <152830401+Pan-chao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivokub ivokub ivokub approved these changes

Assignees

No one assigned

Labels

type: typo Fixes typos in comments or documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bytetigers @CLAassistant @ivokub